Skip to content

Commit dddad10

Browse files
committed
Update ICompletionItems calling pattern
1 parent 8290f3f commit dddad10

File tree

1 file changed

+6
-6
lines changed
  • packages/jupyterlab-lsp/src/adapters/jupyterlab/components

1 file changed

+6
-6
lines changed

packages/jupyterlab-lsp/src/adapters/jupyterlab/components/completion.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ export class LSPConnector extends DataConnector<
265265
end: token.offset + prefix.length,
266266
matches: [],
267267
metadata: {},
268-
items: { items }
268+
items
269269
};
270270
}
271271

@@ -292,7 +292,7 @@ export class LSPConnector extends DataConnector<
292292
items.push({ label: match });
293293
});
294294
}
295-
return { ...reply, items: { items } };
295+
return { ...reply, items };
296296
}
297297

298298
private merge_replies(
@@ -301,14 +301,14 @@ export class LSPConnector extends DataConnector<
301301
editor: CodeEditor.IEditor
302302
): CompletionHandler.IReply {
303303
console.log('[LSP][Completer] Merging completions:', lsp, kernel);
304-
if (!kernel.items.items.length) {
304+
if (!kernel.items.length) {
305305
return lsp;
306306
}
307-
if (!lsp.items.items.length) {
307+
if (!lsp.items.length) {
308308
return kernel;
309309
}
310310
// Combine ICompletionItems across multiple IReply objects
311-
const aggregatedItems = lsp.items.items.concat(kernel.items.items);
311+
const aggregatedItems = lsp.items.concat(kernel.items);
312312
// De-dupe and filter items
313313
const labelSet = new Set<String>();
314314
const processedItems = new Array<CompletionHandler.ICompletionItem>();
@@ -325,7 +325,7 @@ export class LSPConnector extends DataConnector<
325325
});
326326
// TODO: Sort items
327327
// Return reply with processed items.
328-
return { ...lsp, items: { items: processedItems } };
328+
return { ...lsp, items: processedItems };
329329
}
330330

331331
// TODO: Remove this

0 commit comments

Comments
 (0)