Merge pull request #965 from krassowski/better-notifications

Automatically show and dismiss notifications

Author: krassowski

packages/jupyterlab-lsp/src/features/diagnostics/diagnostics.ts

@@ -249,7 +249,10 @@ class DiagnosticsPanel {
           .writeText(message)
           .then(() => {
             Notification.info(
-              this.trans.__('Successfully copied "%1" to clipboard', message)
+              this.trans.__('Successfully copied "%1" to clipboard', message),
+              {
+                autoClose: 3 * 1000
+              }
             );
           })
           .catch(() => {

packages/jupyterlab-lsp/src/features/jump_to.ts

@@ -368,10 +368,9 @@ export class NavigationFeature extends Feature {
     const jumper = this.getJumper(adapter);
 
     if (!targetInfo) {
-      const notificationID = Notification.info(
-        this._trans.__('No jump targets found')
-      );
-      setTimeout(() => Notification.dismiss(notificationID), 2 * 1000);
+      Notification.info(this._trans.__('No jump targets found'), {
+        autoClose: 3 * 1000
+      });
       return JumpResult.NoTargetsFound;
     }
 
@@ -564,12 +563,9 @@ export const JUMP_PLUGIN: JupyterFrontEndPlugin<void> = {
         const { connection, virtualPosition, document, adapter } = context;
 
         if (!connection) {
-          const notificationId = Notification.info(
-            trans.__('Connection not found for jump')
-          );
-          setTimeout(() => {
-            Notification.dismiss(notificationId);
-          }, 2 * 1000);
+          Notification.warning(trans.__('Connection not found for jump'), {
+            autoClose: 4 * 1000
+          });
           return;
         }
 
@@ -610,12 +606,9 @@ export const JUMP_PLUGIN: JupyterFrontEndPlugin<void> = {
         const { connection, virtualPosition, document, adapter } = context;
 
         if (!connection) {
-          const notificationId = Notification.info(
-            trans.__('Connection not found for jump')
-          );
-          setTimeout(() => {
-            Notification.dismiss(notificationId);
-          }, 2 * 1000);
+          Notification.warning(trans.__('Connection not found for jump'), {
+            autoClose: 5 * 1000
+          });
           return;
         }
 

packages/jupyterlab-lsp/src/features/rename.ts

@@ -116,7 +116,9 @@ export class RenameFeature extends Feature {
         severity = 'error';
       }
 
-      Notification.emit(status, severity);
+      Notification.emit(status, severity, {
+        autoClose: (severity === 'error' ? 5 : 3) * 1000
+      });
     } catch (error) {
       this.console.warn(error);
     }
@@ -267,9 +269,11 @@ export const RENAME_PLUGIN: JupyterFrontEndPlugin<void> = {
           }
 
           if (!status) {
-            Notification.error(trans.__(`Rename failed: %1`, error));
+            Notification.error(trans.__(`Rename failed: %1`, error), {
+              autoClose: 5 * 1000
+            });
           } else {
-            Notification.info(status);
+            Notification.warning(status, { autoClose: 3 * 1000 });
           }
         };
 
@@ -287,7 +291,8 @@ export const RENAME_PLUGIN: JupyterFrontEndPlugin<void> = {
             return;
           }
           Notification.info(
-            trans.__('Renaming %1 to %2...', oldValue, newValue)
+            trans.__('Renaming %1 to %2…', oldValue, newValue),
+            { autoClose: 3 * 1000 }
           );
           const edit = await connection!.clientRequests[
             'textDocument/rename'