Merge pull request #143 from yunair/fix_completion_case_sensitive

completion case sensitive will  keep a no need token value

Author: krassowski

CHANGELOG.md

@@ -40,6 +40,10 @@
   - completion now work properly when the kernel is shut down (
     [#146](https://github.com/krassowski/jupyterlab-lsp/pull/146)
     )
+  - a lowercase completion option selected from an uppercase token
+    will now correctly substitute the incomplete token (
+    [#143](https://github.com/krassowski/jupyterlab-lsp/pull/143)
+    )
 
 ## `lsp-ws-connection 0.3.0`
 

atest/05_Features/Completion.robot

@@ -50,6 +50,15 @@ Autocompletes If Only One Option
     Wait Until Keyword Succeeds    20x    0.5s    Cell Editor Should Equal    3    list.clear
     [Teardown]    Clean Up After Working With File    Completion.ipynb
 
+User Can Select Lowercase After Starting Uppercase
+    Setup Notebook    Python    Completion.ipynb
+    Enter Cell Editor    4    line=1
+    Trigger Completer
+    Completer Should Suggest  time
+    Press Keys    None    ENTER
+    Wait Until Keyword Succeeds    20x    0.5s    Cell Editor Should Equal    4    from time import time
+    [Teardown]    Clean Up After Working With File    Completion.ipynb
+
 *** Keywords ***
 Enter Cell Editor
     [Arguments]    ${cell_nr}    ${line}=1

atest/examples/Completion.ipynb

@@ -27,6 +27,15 @@
    "source": [
     "list."
    ]
+  },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "from time import Tim"
+   ]
   }
  ],
  "metadata": {

packages/jupyterlab-lsp/src/adapters/jupyterlab/components/completion.ts

@@ -218,7 +218,7 @@ export class LSPConnector extends DataConnector<
       // sortText: "amean"
       let text = match.insertText ? match.insertText : match.label;
 
-      if (text.startsWith(token.value)) {
+      if (text.toLowerCase().startsWith(token.value.toLowerCase())) {
         all_non_prefixed = false;
       }
 
@@ -282,7 +282,7 @@ export class LSPConnector extends DataConnector<
     if (lsp.start > kernel.start) {
       const cursor = editor.getCursorPosition();
       const line = editor.getLine(cursor.line);
-      prefix = line.substring(kernel.start, kernel.end);
+      prefix = line.substring(cursor.column - 1, cursor.column);
       console.log('will remove prefix from kernel response:', prefix);
     }