Skip to content

Commit ee46daf

Browse files
committed
Fix eliding breaking kernel-only completions on py3.7
caught on CI. It was only a problem for 3.7 because newer versions of IPython include type information for all suggestions.
1 parent a5bb736 commit ee46daf

File tree

1 file changed

+3
-3
lines changed
  • packages/jupyterlab-lsp/src/features/completion

1 file changed

+3
-3
lines changed

packages/jupyterlab-lsp/src/features/completion/renderer.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { Signal } from '@lumino/signaling';
88
import { ILSPLogConsole } from '../../tokens';
99

1010
import { CompletionLabIntegration } from './completion';
11-
import { LazyCompletionItem } from './item';
11+
import { LazyCompletionItem, IExtendedCompletionItem } from './item';
1212

1313
export interface ICompletionData {
1414
item: LazyCompletionItem;
@@ -147,8 +147,8 @@ export class LSPCompletionRenderer
147147
return li;
148148
}
149149

150-
private _elideMark(item: LazyCompletionItem, li: HTMLLIElement) {
151-
if (!item) {
150+
private _elideMark(item: IExtendedCompletionItem, li: HTMLLIElement) {
151+
if (!item || !item.type) {
152152
return;
153153
}
154154
const type = item.type.toLowerCase();

0 commit comments

Comments
 (0)