Skip to content

Commit fa4e576

Browse files
committed
Switch to python-lsp-server for testing
1 parent eaf53f7 commit fa4e576

File tree

8 files changed

+15
-11
lines changed

8 files changed

+15
-11
lines changed

README.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,19 +119,19 @@ Use of a python `virtualenv` or a conda env is also recommended.
119119
> or `jupyter-lsp-r` to install both the server extension and the language server.
120120
121121
1. install LSP servers for languages of your choice; for example, for Python
122-
([pyls](https://github.com/palantir/python-language-server)) and
122+
([pylsp](https://github.com/python-lsp/python-lsp-server)) and
123123
R ([languageserver](https://github.com/REditorSupport/languageserver)) servers:
124124

125125
```bash
126126
# note: you may want to use our fork of python-language-server instead (see below)
127-
pip install 'python-language-server[all]'
127+
pip install 'python-lsp-server[all]'
128128
R -e 'install.packages("languageserver")'
129129
```
130130

131131
or from `conda-forge`
132132

133133
```bash
134-
conda install -c conda-forge python-language-server r-languageserver
134+
conda install -c conda-forge python-lsp-server r-languageserver
135135
```
136136

137137
Please see our full list of
@@ -188,6 +188,8 @@ Use of a python `virtualenv` or a conda env is also recommended.
188188

189189
Server configurations can be edited using the Advanced Settings editor in JupyterLab (_Settings > Advanced Settings Editor_). For settings specific to each server, please see the [table of language servers][language-servers]. Example settings might include:
190190

191+
> Note: for the new (currently recommended) python-lsp-server replace `pyls` occurrences with `pyslp`
192+
191193
```json
192194
{
193195
"language_servers": {

atest/05_Features/Completion.robot

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ Completion Works For Tokens Separated By Space
187187
Wait Until Keyword Succeeds 40x 0.5s Cell Editor Should Equal 13 from statistics import
188188

189189
Kernel And LSP Completions Merge Prefix Conflicts Are Resolved
190-
[Documentation] Reconciliate Python kernel returning prefixed completions and LSP (pyls) not-prefixed ones
190+
[Documentation] Reconciliate Python kernel returning prefixed completions and LSP (pylsp) not-prefixed ones
191191
Configure JupyterLab Plugin {"kernelResponseTimeout": -1, "waitForBusyKernel": false} plugin id=${COMPLETION PLUGIN ID}
192192
# For more details see: https://github.com/krassowski/jupyterlab-lsp/issues/30#issuecomment-576003987
193193
# `import os.pat<tab>` → `import os.pathsep`

atest/07_Configuration.robot

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ Resource ./Keywords.robot
77
*** Test Cases ***
88
Python
99
[Documentation] pyflakes is enabled by default, but flake8 is not
10-
Settings Should Change Editor Diagnostics Python style.py pyls
11-
... {"pyls": {"plugins": {"flake8": {"enabled": true},"pyflakes": {"enabled": false}}}}
10+
Settings Should Change Editor Diagnostics Python style.py pylsp
11+
... {"pylsp": {"plugins": {"flake8": {"enabled": true},"pyflakes": {"enabled": false}}}}
1212
... undefined name 'foo' (pyflakes)
1313
... undefined name 'foo' (flake8)
1414

atest/Variables.robot

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,5 +54,5 @@ ${JLAB XP CLOSE SETTINGS} ${JLAB XP DOCK TAB}\[contains(., 'Settings')]/*[con
5454
${CSS DIAGNOSTIC} css:.cm-lsp-diagnostic
5555
# log messages
5656
@{KNOWN BAD ERRORS}
57-
... pyls_jsonrpc.endpoint - Failed to handle notification
58-
... pyls_jsonrpc.endpoint - Failed to handle request
57+
... pylsp_jsonrpc.endpoint - Failed to handle notification
58+
... pylsp_jsonrpc.endpoint - Failed to handle request

python_packages/jupyter_lsp/jupyter_lsp/specs/python_lsp_server.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33

44

55
class PythonLSPServer(PythonModuleSpec):
6-
python_module = key = "python-lsp-server"
6+
python_module = "pylsp"
7+
key = "python-lsp-server"
78
languages = ["python"]
89
spec = dict(
910
display_name="python-lsp-server",

python_packages/jupyter_lsp/jupyter_lsp/tests/conftest.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
"dockerfile-language-server-nodejs",
2121
"javascript-typescript-langserver",
2222
"pyls",
23+
"python-lsp-server",
2324
"unified-language-server",
2425
"sql-language-server",
2526
"vscode-css-languageserver-bin",

python_packages/jupyter_lsp/jupyter_lsp/tests/test_session.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ async def test_start_unknown(known_unknown_server, handlers, jsonrpc_init_msg):
7878
@pytest.mark.asyncio
7979
async def test_ping(handlers):
8080
"""see https://github.com/krassowski/jupyterlab-lsp/issues/458"""
81-
a_server = "pyls"
81+
a_server = "pylsp"
8282

8383
handler, ws_handler = handlers
8484
manager = handler.manager

requirements/utest.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ pytest-asyncio
55
pytest-cov
66
pytest-flake8
77
pytest-runner
8-
python-language-server
8+
python-lsp-server
99
pluggy<1.0,>=0.12 # Python 3.5 CI Travis, may need update with new pytest releases, see issue 259

0 commit comments

Comments
 (0)