Skip to content

Commit 152c20f

Browse files
fresendelresende
authored andcommitted
Enable specifying helm chart deployment namespace
Fixes #1407
1 parent cfbe01e commit 152c20f

File tree

7 files changed

+7
-7
lines changed

7 files changed

+7
-7
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ WHEEL_FILE:=dist/jupyter_enterprise_gateway-$(VERSION)-py3-none-any.whl
2929
SDIST_FILE:=dist/jupyter_enterprise_gateway-$(VERSION).tar.gz
3030
DIST_FILES=$(WHEEL_FILE) $(SDIST_FILE)
3131

32-
HELM_DESIRED_VERSION:=v3.8.2 # Pin the version of helm to use (v3.8.2 is latest as of 4/21/22)
32+
HELM_DESIRED_VERSION:=v3.18.3 # Pin the version of helm to use (v3.18.3 is latest as of 6/21/25)
3333
HELM_CHART_VERSION:=$(shell grep version: etc/kubernetes/helm/enterprise-gateway/Chart.yaml | sed 's/version: //')
3434
HELM_CHART_PACKAGE:=dist/enterprise-gateway-$(HELM_CHART_VERSION).tgz
3535
HELM_CHART:=dist/jupyter_enterprise_gateway_helm-$(VERSION).tar.gz

etc/kubernetes/helm/enterprise-gateway/templates/daemonset.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ apiVersion: apps/v1
33
kind: DaemonSet
44
metadata:
55
name: kernel-image-puller
6-
namespace: {{ .Release.Namespace }}
6+
namespace: {{ .Values.namespace | default .Release.Namespace }}
77
labels:
88
gateway-selector: enterprise-gateway
99
app: enterprise-gateway

etc/kubernetes/helm/enterprise-gateway/templates/deployment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ apiVersion: apps/v1
33
kind: Deployment
44
metadata:
55
name: enterprise-gateway
6-
namespace: {{ .Release.Namespace }}
6+
namespace: {{ .Values.namespace | default .Release.Namespace }}
77
labels:
88
gateway-selector: enterprise-gateway
99
app: enterprise-gateway

etc/kubernetes/helm/enterprise-gateway/templates/eg-serviceaccount.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ imagePullSecrets:
1111
{{- end }}
1212
metadata:
1313
name: {{ .Values.deployment.serviceAccountName }}
14-
namespace: {{ .Release.Namespace }}
14+
namespace: {{ .Values.namespace | default .Release.Namespace }}
1515
labels:
1616
app: enterprise-gateway
1717
component: enterprise-gateway

etc/kubernetes/helm/enterprise-gateway/templates/ingress.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ apiVersion: extensions/v1beta1
99
{{- end }}
1010
kind: Ingress
1111
metadata:
12-
namespace: {{ .Release.Namespace }}
12+
namespace: {{ .Values.namespace | default .Release.Namespace }}
1313
name: enterprise-gateway-ingress
1414
{{- if .Values.ingress.annotations }}
1515
annotations:

etc/kubernetes/helm/enterprise-gateway/templates/kip-serviceaccount.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ imagePullSecrets:
1111
{{- end }}
1212
metadata:
1313
name: {{ .Values.kip.serviceAccountName }}
14-
namespace: {{ .Release.Namespace }}
14+
namespace: {{ .Values.namespace | default .Release.Namespace }}
1515
labels:
1616
app: enterprise-gateway
1717
component: enterprise-gateway

etc/kubernetes/helm/enterprise-gateway/templates/service.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ metadata:
1313
{{- end }}
1414

1515
name: enterprise-gateway
16-
namespace: {{ .Release.Namespace }}
16+
namespace: {{ .Values.namespace | default .Release.Namespace }}
1717
spec:
1818
ports:
1919
{{- range $key, $val := .Values.service.ports }}

0 commit comments

Comments
 (0)