Skip to content

Commit 027c090

Browse files
committed
fix pytests
1 parent 66c89c1 commit 027c090

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

conftest.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from pathlib import Path
2+
from unittest.mock import AsyncMock, Mock
23

34
import pytest
45
from sqlalchemy import create_engine
@@ -59,6 +60,7 @@ def jp_scheduler(jp_scheduler_db_url, jp_scheduler_root_dir, jp_scheduler_db):
5960
db_url=jp_scheduler_db_url,
6061
root_dir=str(jp_scheduler_root_dir),
6162
environments_manager=MockEnvironmentManager(),
63+
dask_client_future=AsyncMock(),
6264
)
6365

6466

jupyter_scheduler/tests/test_job_files_manager.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import tarfile
55
import time
66
from pathlib import Path
7-
from unittest.mock import patch
7+
from unittest.mock import AsyncMock, patch
88

99
import pytest
1010

@@ -41,13 +41,16 @@ async def test_copy_from_staging():
4141
}
4242
output_dir = "jobs/1"
4343
with patch("jupyter_scheduler.job_files_manager.Downloader") as mock_downloader:
44-
with patch("jupyter_scheduler.job_files_manager.Process") as mock_process:
44+
with patch("jupyter_scheduler.scheduler.DaskClient") as mock_dask_future:
4545
with patch("jupyter_scheduler.scheduler.Scheduler") as mock_scheduler:
46+
mock_downloader.return_value.download = AsyncMock()
4647
mock_scheduler.get_job.return_value = job
4748
mock_scheduler.get_staging_paths.return_value = staging_paths
4849
mock_scheduler.get_local_output_path.return_value = output_dir
4950
mock_scheduler.get_job_filenames.return_value = job_filenames
50-
manager = JobFilesManager(scheduler=mock_scheduler)
51+
manager = JobFilesManager(
52+
scheduler=mock_scheduler, dask_client_future=mock_dask_future
53+
)
5154
await manager.copy_from_staging(1)
5255

5356
mock_downloader.assert_called_once_with(

0 commit comments

Comments
 (0)