Skip to content

Commit 1fa3c1c

Browse files
committed
update local var names to notificationsSettings
1 parent d71bb3a commit 1fa3c1c

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

src/components/notification-detail.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ interface INotificationsSettingsItemProps {
1111
}
1212

1313
interface INotificationsSettingsDetailsProps {
14-
notification: Scheduler.INotificationsSettings;
14+
notificationsSettings: Scheduler.INotificationsSettings;
1515
}
1616

1717
const NotificationsSettingsItem: React.FC<INotificationsSettingsItemProps> = ({
@@ -32,7 +32,7 @@ const NotificationsSettingsItem: React.FC<INotificationsSettingsItemProps> = ({
3232

3333
export const NotificationsSettingsDetails: React.FC<
3434
INotificationsSettingsDetailsProps
35-
> = ({ notification }) => {
35+
> = ({ notificationsSettings }) => {
3636
const trans = useTranslator('jupyterlab');
3737

3838
return (
@@ -43,7 +43,7 @@ export const NotificationsSettingsDetails: React.FC<
4343
</FormLabel>
4444
<Stack spacing={2}>
4545
<FormLabel component="legend">{trans.__('Send To')}</FormLabel>
46-
{notification.send_to.map((email, idx) => (
46+
{notificationsSettings.send_to.map((email, idx) => (
4747
<NotificationsSettingsItem
4848
key={idx}
4949
label={trans.__(`Send To ${idx + 1}`)}
@@ -53,7 +53,7 @@ export const NotificationsSettingsDetails: React.FC<
5353
<FormLabel component="legend">
5454
{trans.__('Notification Events')}
5555
</FormLabel>
56-
{notification.events.map((event, idx) => (
56+
{notificationsSettings.events.map((event, idx) => (
5757
<NotificationsSettingsItem
5858
key={idx}
5959
label={trans.__(`Event ${idx + 1}`)}
@@ -62,7 +62,7 @@ export const NotificationsSettingsDetails: React.FC<
6262
))}
6363
<NotificationsSettingsItem
6464
label={trans.__('Include Output')}
65-
value={notification.include_output}
65+
value={notificationsSettings.include_output}
6666
/>
6767
</Stack>
6868
</CardContent>

src/mainviews/detail-view/job-definition.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ export function JobDefinition(props: IJobDefinitionProps): JSX.Element {
291291
{JobsList}
292292
{props.model.notificationsSettings && (
293293
<NotificationsSettingsDetails
294-
notification={props.model.notificationsSettings}
294+
notificationsSettings={props.model.notificationsSettings}
295295
/>
296296
)}
297297
{AdvancedOptions}

src/mainviews/detail-view/job-detail.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ export function JobDetail(props: IJobDetailProps): JSX.Element {
354354
{Parameters}
355355
{props.model.notificationsSettings && (
356356
<NotificationsSettingsDetails
357-
notification={props.model.notificationsSettings}
357+
notificationsSettings={props.model.notificationsSettings}
358358
/>
359359
)}
360360
{AdvancedOptions}

0 commit comments

Comments
 (0)