Skip to content

Commit 2c5c289

Browse files
committed
add and use create_job_definition helper function
1 parent 5fa81a2 commit 2c5c289

File tree

1 file changed

+16
-7
lines changed

1 file changed

+16
-7
lines changed

jupyter_scheduler/tests/test_scheduler.py

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,14 @@
1515
)
1616
from jupyter_scheduler.orm import JobDefinition
1717

18-
test_job_definition_parameters = {
18+
test_job_def_params = {
1919
"input_uri": "helloworld.ipynb",
2020
"runtime_environment_name": "default",
2121
"name": "hello world",
2222
"output_formats": ["ipynb"],
2323
}
2424

25+
<<<<<<< HEAD
2526

2627
def test_create_job_definition(jp_scheduler):
2728
with patch("jupyter_scheduler.scheduler.fsspec") as mock_fsspec:
@@ -30,6 +31,18 @@ def test_create_job_definition(jp_scheduler):
3031
job_definition_id = jp_scheduler.create_job_definition(
3132
CreateJobDefinition(**test_job_definition_parameters)
3233
)
34+
=======
35+
def create_job_definition(jp_scheduler, job_def_params):
36+
with patch("jupyter_scheduler.scheduler.fsspec") as mock_fsspec:
37+
with patch("jupyter_scheduler.scheduler.Scheduler.file_exists") as mock_file_exists:
38+
mock_file_exists.return_value = True
39+
job_definition_id = jp_scheduler.create_job_definition(CreateJobDefinition(**job_def_params))
40+
41+
return job_definition_id
42+
43+
def test_create_job_definition(jp_scheduler):
44+
job_definition_id = create_job_definition(jp_scheduler, test_job_def_params)
45+
>>>>>>> fb76d81 (add and use create_job_definition helper function)
3346

3447
with jp_scheduler.db_session() as session:
3548
definitions = session.query(JobDefinition).all()
@@ -47,12 +60,8 @@ def test_create_job_definition(jp_scheduler):
4760

4861

4962
def test_create_job_definition_with_on_events(jp_scheduler):
50-
with patch("jupyter_scheduler.scheduler.fsspec") as mock_fsspec:
51-
with patch("jupyter_scheduler.scheduler.Scheduler.file_exists") as mock_file_exists:
52-
mock_file_exists.return_value = True
53-
event_type = EventType(**event_type_parameters)
54-
params_with_on_events = {**test_job_definition_parameters, "on_events": [event_type]}
55-
jp_scheduler.create_job_definition(CreateJobDefinition(**params_with_on_events))
63+
params_with_on_events = {**test_job_def_params, "on_events": [EventType(**event_type_parameters)]}
64+
create_job_definition(jp_scheduler, params_with_on_events)
5665

5766
with jp_scheduler.db_session() as session:
5867
definitions = session.query(JobDefinition).all()

0 commit comments

Comments
 (0)