Skip to content

Commit 7972820

Browse files
committed
fix existing pytests
1 parent ae39f5d commit 7972820

File tree

4 files changed

+15
-2
lines changed

4 files changed

+15
-2
lines changed

conftest.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
from jupyter_scheduler.orm import create_session, create_tables
77
from jupyter_scheduler.scheduler import Scheduler
8-
from jupyter_scheduler.tests.mocks import MockEnvironmentManager
8+
from jupyter_scheduler.tests.mocks import MockDownloadManager, MockEnvironmentManager
99

1010
pytest_plugins = ("jupyter_server.pytest_plugin",)
1111

@@ -46,5 +46,8 @@ def jp_scheduler_db():
4646
@pytest.fixture
4747
def jp_scheduler(jp_data_dir):
4848
return Scheduler(
49-
db_url=DB_URL, root_dir=str(jp_data_dir), environments_manager=MockEnvironmentManager()
49+
db_url=DB_URL,
50+
root_dir=str(jp_data_dir),
51+
environments_manager=MockEnvironmentManager(),
52+
download_manager=MockDownloadManager(DB_URL),
5053
)

jupyter_scheduler/tests/mocks.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
from typing import Dict, List
22

3+
from jupyter_scheduler.download_manager import DownloadManager
34
from jupyter_scheduler.environments import EnvironmentManager
45
from jupyter_scheduler.executors import ExecutionManager
56
from jupyter_scheduler.models import JobFeature, RuntimeEnvironment, UpdateJobDefinition
@@ -73,3 +74,8 @@ def pause_jobs(self, job_definition_id: str):
7374

7475
def resume_jobs(self, job_definition_id: str):
7576
pass
77+
78+
79+
class MockDownloadManager(DownloadManager):
80+
def __init__(self, db_url: str):
81+
pass

jupyter_scheduler/tests/test_job_files_manager.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ async def test_copy_from_staging():
5656
staging_paths=staging_paths,
5757
output_dir=output_dir,
5858
redownload=False,
59+
include_staging_files=None,
5960
)
6061

6162

jupyter_scheduler/tests/test_scheduler.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ def test_create_job_definition(jp_scheduler):
4949
"update_time": 1,
5050
"create_time": 1,
5151
"active": True,
52+
"packaged_files": [],
5253
}
5354

5455
job_definition_2 = {
@@ -62,6 +63,7 @@ def test_create_job_definition(jp_scheduler):
6263
"create_time": 2,
6364
"active": True,
6465
"tags": ["tag_2"],
66+
"packaged_files": [],
6567
}
6668

6769
job_definition_3 = {
@@ -75,6 +77,7 @@ def test_create_job_definition(jp_scheduler):
7577
"create_time": 3,
7678
"active": False,
7779
"tags": ["tag_3"],
80+
"packaged_files": [],
7881
}
7982

8083

0 commit comments

Comments
 (0)