Skip to content

Commit d4abf04

Browse files
committed
return create_job_definition
1 parent eebf893 commit d4abf04

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

jupyter_scheduler/tests/test_scheduler.py

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,23 @@
2222
"output_formats": ["ipynb"],
2323
}
2424

25+
event_type_parameters = {"name": "type1", "parameters": {"param1": "value1"}}
2526

26-
def test_create_job_definition(jp_scheduler):
27+
28+
def create_job_definition(jp_scheduler, job_def_params):
2729
with patch("jupyter_scheduler.scheduler.fsspec") as mock_fsspec:
2830
with patch("jupyter_scheduler.scheduler.Scheduler.file_exists") as mock_file_exists:
2931
mock_file_exists.return_value = True
3032
job_definition_id = jp_scheduler.create_job_definition(
31-
CreateJobDefinition(**test_job_def_params)
33+
CreateJobDefinition(**job_def_params)
3234
)
3335

36+
return job_definition_id
37+
38+
39+
def test_create_job_definition(jp_scheduler):
40+
job_definition_id = create_job_definition(jp_scheduler, test_job_def_params)
41+
3442
with jp_scheduler.db_session() as session:
3543
definitions = session.query(JobDefinition).all()
3644
assert 1 == len(definitions)
@@ -43,9 +51,6 @@ def test_create_job_definition(jp_scheduler):
4351
assert [] == definition.on_events
4452

4553

46-
event_type_parameters = {"name": "type1", "parameters": {"param1": "value1"}}
47-
48-
4954
def test_create_job_definition_with_on_events(jp_scheduler):
5055
params_with_on_events = {
5156
**test_job_def_params,

0 commit comments

Comments
 (0)