Skip to content

Commit 233f676

Browse files
authored
Merge pull request #230 from blink1073/fix-docs-header
2 parents f827a42 + 4d730dd commit 233f676

File tree

3 files changed

+13
-16
lines changed

3 files changed

+13
-16
lines changed

jupyter_releaser/changelog.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -125,15 +125,12 @@ def get_version_entry(
125125
entry = "\n".join(entry).strip()
126126

127127
# Remove empty documentation entry if only automated changelogs were there
128-
if "# Documentation improvements\n\n" in entry:
128+
if (
129+
"# Documentation improvements" in entry
130+
and not "# Documentation improvements\n\n-" in entry
131+
):
129132
entry = re.sub(r"#+ Documentation improvements\n\n", "", entry)
130133

131-
# Replace "*" unordered list marker with "-" since this is what
132-
# Prettier uses
133-
# TODO: remove after github_activity 0.1.4+ is available
134-
entry = re.sub(r"^\* ", "- ", entry)
135-
entry = re.sub(r"\n\* ", "\n- ", entry)
136-
137134
output = f"""
138135
## {version}
139136

jupyter_releaser/tests/util.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,14 @@
2929
3030
### Merged PRs
3131
32-
* defining contributions [#14](https://github.com/executablebooks/github-activity/pull/14) ([@choldgraf](https://github.com/choldgraf))
33-
* updating CLI for new tags [#12](https://github.com/executablebooks/github-activity/pull/12) ([@choldgraf](https://github.com/choldgraf))
34-
* fixing link to changelog with refs [#11](https://github.com/executablebooks/github-activity/pull/11) ([@choldgraf](https://github.com/choldgraf))
35-
* adding contributors list [#10](https://github.com/executablebooks/github-activity/pull/10) ([@choldgraf](https://github.com/choldgraf))
36-
* some improvements to `since` and opened issues list [#8](https://github.com/executablebooks/github-activity/pull/8) ([@choldgraf](https://github.com/choldgraf))
37-
* Support git references etc. [#6](https://github.com/executablebooks/github-activity/pull/6) ([@consideRatio](https://github.com/consideRatio))
38-
* adding authentication information [#2](https://github.com/executablebooks/github-activity/pull/2) ([@choldgraf](https://github.com/choldgraf))
39-
* {PR_ENTRY}
32+
- defining contributions [#14](https://github.com/executablebooks/github-activity/pull/14) ([@choldgraf](https://github.com/choldgraf))
33+
- updating CLI for new tags [#12](https://github.com/executablebooks/github-activity/pull/12) ([@choldgraf](https://github.com/choldgraf))
34+
- fixing link to changelog with refs [#11](https://github.com/executablebooks/github-activity/pull/11) ([@choldgraf](https://github.com/choldgraf))
35+
- adding contributors list [#10](https://github.com/executablebooks/github-activity/pull/10) ([@choldgraf](https://github.com/choldgraf))
36+
- some improvements to `since` and opened issues list [#8](https://github.com/executablebooks/github-activity/pull/8) ([@choldgraf](https://github.com/choldgraf))
37+
- Support git references etc. [#6](https://github.com/executablebooks/github-activity/pull/6) ([@consideRatio](https://github.com/consideRatio))
38+
- adding authentication information [#2](https://github.com/executablebooks/github-activity/pull/2) ([@choldgraf](https://github.com/choldgraf))
39+
- {PR_ENTRY}
4040
4141
### Contributors to this release
4242

setup.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ install_requires =
3131
check-manifest
3232
click
3333
ghapi
34-
github-activity~=0.1
34+
github-activity~=0.2
3535
importlib_resources
3636
jsonschema>=3.0.1
3737
pre-commit

0 commit comments

Comments
 (0)