Skip to content

Commit 28db9ca

Browse files
authored
Merge pull request #46 from jtpio/handle-missing-version
Handle missing `version` from `package.json`
2 parents 47de0cd + 1b8253d commit 28db9ca

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

jupyter_releaser/npm.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,16 +145,17 @@ def get_package_versions(version):
145145
"""Get the formatted list of npm package names and versions"""
146146
message = ""
147147
data = json.loads(PACKAGE_JSON.read_text(encoding="utf-8"))
148-
if data["version"] != version:
148+
npm_version = data.get("version", "")
149+
if npm_version != version:
149150
message += f"\nPython version: {version}"
150-
message += f'\nnpm version: {data["name"]}: {data["version"]}'
151+
message += f'\nnpm version: {data["name"]}: {npm_version}'
151152
if "workspaces" in data:
152153
message += "\nnpm workspace versions:"
153154
for pattern in _get_workspace_packages(data):
154155
for path in glob(pattern, recursive=True):
155156
text = Path(path).joinpath("package.json").read_text()
156157
data = json.loads(text)
157-
message += f'\n{data["name"]}: {data["version"]}'
158+
message += f'\n{data["name"]}: {data.get("version", "")}'
158159
return message
159160

160161

0 commit comments

Comments
 (0)