Skip to content

Commit 3000d6c

Browse files
authored
Merge v2 into main (#415)
* create v2 branch * Remove check links and check manifest (#395) * Clean up Extract Release (#396) * Simplified Workflow (#397) * Install the version2 branch in common action (#400) * Clean up asset sha handling (#401) * Fix handling of asset_shas check (#402) * Fix twine repository handling (#404) * Fix handling of changelog entry (#405) * Fix default twine registry (#408) * Fix default twine registry again (#410) * Run mdformat on the manually formatted changelog entry (#413) * Update docs for simplified workflow (#414)
1 parent 504926f commit 3000d6c

38 files changed

+535
-830
lines changed

.github/actions/check-links/action.yml

Lines changed: 0 additions & 28 deletions
This file was deleted.

.github/actions/check-release/action.yml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -20,32 +20,32 @@ runs:
2020
# Install Jupyter Releaser from git unless we are testing Releaser itself
2121
if ! command -v jupyter-releaser &> /dev/null
2222
then
23-
pip install -q git+https://github.com/jupyter-server/jupyter_releaser.git@v1
23+
pip install -q git+https://github.com/jupyter-server/jupyter_releaser.git@version2
2424
fi
2525
26-
- id: draft-changelog
26+
- id: prep-release
2727
shell: bash -eux {0}
2828
run: |
29-
export RH_IS_CHECK_RELEASE="true"
29+
export RH_DRY_RUN="true"
3030
export GITHUB_ACCESS_TOKEN=${{ inputs.token }}
3131
export RH_VERSION_SPEC=${{ inputs.version_spec }}
3232
export RH_STEPS_TO_SKIP=${{ inputs.steps_to_skip }}
33-
python -m jupyter_releaser.actions.draft_changelog
33+
python -m jupyter_releaser.actions.prep_release
3434
35-
- id: draft-release
35+
- id: populate-release
3636
shell: bash -eux {0}
3737
run: |
38-
export RH_IS_CHECK_RELEASE="true"
38+
export RH_DRY_RUN="true"
3939
export GITHUB_ACCESS_TOKEN=${{ inputs.token }}
40-
export RH_RELEASE_URL=${{ steps.draft-changelog.outputs.release_url }}
40+
export RH_RELEASE_URL=${{ steps.prep-release.outputs.release_url }}
4141
export RH_STEPS_TO_SKIP=${{ inputs.steps_to_skip }}
42-
python -m jupyter_releaser.actions.draft_release
42+
python -m jupyter_releaser.actions.populate_release
4343
44-
- id: publish-release
44+
- id: finalize-release
4545
shell: bash -eux {0}
4646
run: |
47-
export RH_IS_CHECK_RELEASE="true"
47+
export RH_DRY_RUN="true"
4848
export GITHUB_ACCESS_TOKEN=${{ inputs.token }}
49-
export RH_RELEASE_URL=${{ steps.draft-changelog.outputs.release_url }}
49+
export RH_RELEASE_URL=${{ steps.populate-release.outputs.release_url }}
5050
export RH_STEPS_TO_SKIP=${{ inputs.steps_to_skip }}
51-
python -m jupyter_releaser.actions.publish_release
51+
python -m jupyter_releaser.actions.finalize_release

.github/actions/publish-release/action.yml renamed to .github/actions/finalize-release/action.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: "Publish Release"
1+
name: "Finalize Release"
22
description: "Publish assets and finalize GitHub release"
33
inputs:
44
token:
@@ -24,10 +24,10 @@ inputs:
2424
outputs:
2525
release_url:
2626
description: "The html URL of the GitHub release"
27-
value: ${{ steps.publish-release.outputs.release_url }}
27+
value: ${{ steps.finalize-release.outputs.release_url }}
2828
pr_url:
2929
description: "The html URL of the forwardport PR if applicable"
30-
value: ${{ steps.publish-release.outputs.pr_url }}
30+
value: ${{ steps.finalize-release.outputs.pr_url }}
3131

3232
runs:
3333
using: "composite"
@@ -40,7 +40,7 @@ runs:
4040
then
4141
pip install -q git+https://github.com/jupyter-server/jupyter_releaser.git@v1
4242
fi
43-
- id: publish-release
43+
- id: finalize-release
4444
shell: bash -eux {0}
4545
run: |
4646
export GITHUB_ACCESS_TOKEN=${{ inputs.token }}
@@ -49,4 +49,4 @@ runs:
4949
export RH_RELEASE_URL=${{ inputs.release_url }}
5050
export RH_STEPS_TO_SKIP=${{ inputs.steps_to_skip }}
5151
export RH_BRANCH=${{ inputs.branch }}
52-
python -m jupyter_releaser.actions.publish_release
52+
python -m jupyter_releaser.actions.finalize_release

.github/actions/install-releaser/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ runs:
1010
# Install Jupyter Releaser from git unless we are testing Releaser itself
1111
if ! command -v jupyter-releaser &> /dev/null
1212
then
13-
pip install -q git+https://github.com/jupyter-server/jupyter_releaser.git@v1
13+
pip install -q git+https://github.com/jupyter-server/jupyter_releaser.git@version2
1414
fi

.github/actions/draft-release/action.yml renamed to .github/actions/populate-release/action.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
name: "Draft Release"
2-
description: "Create a draft GitHub Release"
1+
name: "Populate Release"
2+
description: "Populate the Draft GitHub Release"
33
inputs:
44
token:
55
description: "GitHub access token"
@@ -24,7 +24,7 @@ inputs:
2424
outputs:
2525
release_url:
2626
description: "The html URL of the draft GitHub release"
27-
value: ${{ steps.draft-release.outputs.release_url }}
27+
value: ${{ steps.populate-release.outputs.release_url }}
2828

2929
runs:
3030
using: "composite"
@@ -35,10 +35,10 @@ runs:
3535
# Install Jupyter Releaser from git unless we are testing Releaser itself
3636
if ! command -v jupyter-releaser &> /dev/null
3737
then
38-
pip install -q git+https://github.com/jupyter-server/jupyter_releaser.git@v1
38+
pip install -q git+https://github.com/jupyter-server/jupyter_releaser.git@version2
3939
fi
4040
41-
- id: draft-release
41+
- id: populate-release
4242
shell: bash -eux {0}
4343
run: |
4444
export GITHUB_ACCESS_TOKEN=${{ inputs.token }}
@@ -47,4 +47,4 @@ runs:
4747
export RH_STEPS_TO_SKIP=${{ inputs.steps_to_skip }}
4848
export RH_RELEASE_URL=${{ inputs.release_url }}
4949
export RH_BRANCH=${{ inputs.branch }}
50-
python -m jupyter_releaser.actions.draft_release
50+
python -m jupyter_releaser.actions.populate_release

.github/actions/draft-changelog/action.yml renamed to .github/actions/prep-release/action.yml

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
name: "Draft Changelog"
2-
description: "Create an automated changelog entry PR"
1+
name: "Prep Release"
2+
description: "Start the Release Process"
33
inputs:
44
token:
55
description: "GitHub access token"
@@ -28,12 +28,9 @@ inputs:
2828
description: "Use PRs with activity since the last stable git tag"
2929
required: false
3030
outputs:
31-
pr_url:
32-
description: "The URL of the Changelog Pull Request"
33-
value: ${{ steps.draft-changelog.outputs.pr_url }}
3431
release_url:
3532
description: "The html URL of the draft GitHub release"
36-
value: ${{ steps.draft-changelog.outputs.release_url }}
33+
value: ${{ steps.prep-release.outputs.release_url }}
3734
runs:
3835
using: "composite"
3936
steps:
@@ -43,10 +40,10 @@ runs:
4340
# Install Jupyter Releaser from git unless we are testing Releaser itself
4441
if ! command -v jupyter-releaser &> /dev/null
4542
then
46-
pip install -q git+https://github.com/jupyter-server/jupyter_releaser.git@v1
43+
pip install -q git+https://github.com/jupyter-server/jupyter_releaser.git@version2
4744
fi
4845
49-
- id: draft-changelog
46+
- id: prep-release
5047
shell: bash -eux {0}
5148
run: |
5249
export GITHUB_ACCESS_TOKEN=${{ inputs.token }}
@@ -60,4 +57,4 @@ runs:
6057
export RH_SINCE=${{ inputs.since }}
6158
export RH_SINCE_LAST_STABLE=${{ inputs.since_last_stable }}
6259
63-
python -m jupyter_releaser.actions.draft_changelog
60+
python -m jupyter_releaser.actions.prep_release

.github/scripts/bump_tag.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ set -eux
22

33
# Update the v1 tag for GitHub Actions consumers
44
if [[ ${RH_DRY_RUN:=true} != 'true' ]]; then
5-
git tag -f -a v1 -m "Github Action release"
5+
git tag -f -a v2 -m "Github Action release"
66
git push origin -f --tags
77
fi

.github/workflows/draft-release.yml

Lines changed: 0 additions & 48 deletions
This file was deleted.

.github/workflows/full-release.yml

Lines changed: 0 additions & 77 deletions
This file was deleted.

.github/workflows/draft-changelog.yml renamed to .github/workflows/prep-release.yml

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: "Step 1: Draft Changelog"
1+
name: "Step 1: Prep Release"
22
on:
33
workflow_dispatch:
44
inputs:
@@ -23,7 +23,7 @@ on:
2323
required: false
2424
type: boolean
2525
jobs:
26-
draft_changelog:
26+
prep_release:
2727
runs-on: ubuntu-latest
2828
strategy:
2929
fail-fast: true
@@ -34,11 +34,11 @@ jobs:
3434
uses: actions/checkout@v2
3535

3636
- name: Setup
37-
uses: ./.github/actions/common
37+
uses: jupyter-releaser/.github/actions/common@version2
3838

39-
- name: Draft Changelog
40-
id: draft-changelog
41-
uses: ./.github/actions/draft-changelog
39+
- name: Prep Release
40+
id: prep-release
41+
uses: jupyter-releaser/.github/actions/prep-release@version2
4242
with:
4343
token: ${{ secrets.ADMIN_GITHUB_TOKEN }}
4444
version_spec: ${{ github.event.inputs.version_spec }}
@@ -50,8 +50,7 @@ jobs:
5050

5151
- name: "** Next Step **"
5252
run: |
53-
echo "Review PR: ${{ steps.draft-changelog.outputs.pr_url }}"
54-
echo "Optional): Review Draft Release: ${{ steps.draft-changelog.outputs.release_url }}"
53+
echo "Optional): Review Draft Release: ${{ steps.prep-release.outputs.release_url }}"
5554
echo "## Next Step" >> $GITHUB_STEP_SUMMARY
56-
echo "Review PR: ${{ steps.draft-changelog.outputs.pr_url }}" >> $GITHUB_STEP_SUMMARY
57-
echo "(Optional): Review Draft Release: ${{ steps.draft-changelog.outputs.release_url }}" >> $GITHUB_STEP_SUMMARY
55+
echo "(Optional): Review Draft Release: ${{ steps.prep-release.outputs.release_url }}" >> $GITHUB_STEP_SUMMARY
56+
echo "Run Step 2: Publish Release workflow"

0 commit comments

Comments
 (0)