Skip to content

Commit 3d0b031

Browse files
authored
Store ref in metadata file (#375)
1 parent 4634184 commit 3d0b031

File tree

4 files changed

+23
-3
lines changed

4 files changed

+23
-3
lines changed

jupyter_releaser/actions/draft_release.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212

1313
setup()
1414

15+
if not os.environ.get("RH_RELEASE_URL"):
16+
raise RuntimeError("Cannot complete Draft Release, no draft GitHub release url found!")
17+
1518
changelog_location = None
1619
changelog_text = ""
1720

jupyter_releaser/cli.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -376,6 +376,7 @@ def draft_changelog(
376376
"""Create a changelog entry PR"""
377377
lib.draft_changelog(
378378
version_spec,
379+
ref,
379380
branch,
380381
repo,
381382
since,

jupyter_releaser/lib.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ def check_links(ignore_glob, ignore_links, cache_file, links_expire):
109109

110110
def draft_changelog(
111111
version_spec,
112+
ref,
112113
branch,
113114
repo,
114115
since,
@@ -157,6 +158,7 @@ def draft_changelog(
157158

158159
data = dict(
159160
version_spec=version_spec,
161+
ref=ref,
160162
branch=branch,
161163
repo=repo,
162164
since=since,

jupyter_releaser/util.py

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,10 @@ def latest_draft_release(gh, branch=None):
341341
"""Get the latest draft release for a given repo"""
342342
newest_time = None
343343
newest_release = None
344+
if branch:
345+
log(f"Getting latest draft release on branch {branch}")
346+
else:
347+
log("Getting latest draft release")
344348
for release in gh.repos.list_releases():
345349
if str(release.draft).lower() == "false":
346350
continue
@@ -351,6 +355,10 @@ def latest_draft_release(gh, branch=None):
351355
if newest_time is None or d_created > newest_time:
352356
newest_time = d_created
353357
newest_release = release
358+
if not newest_release:
359+
log("No draft release found!")
360+
else:
361+
log(f"Found draft release at {newest_release.html_url}")
354362
return newest_release
355363

356364

@@ -469,6 +477,8 @@ def extract_metadata_from_release_url(gh, release_url, auth):
469477
os.environ["RH_BRANCH"] = data["branch"]
470478
if "since" in data:
471479
os.environ["RH_SINCE"] = data["since"]
480+
if "ref" in data:
481+
os.environ["RH_REF"] = data["ref"]
472482
if "since_last_stable" in data:
473483
os.environ["RH_SINCE_LAST_STABLE"] = str(data["since_last_stable"])
474484

@@ -479,8 +489,10 @@ def prepare_environment():
479489
"""Prepare the environment variables, for use when running one of the
480490
action scripts."""
481491
# Set up env variables
482-
os.environ.setdefault("RH_REPOSITORY", os.environ["GITHUB_REPOSITORY"])
483-
os.environ.setdefault("RH_REF", os.environ["GITHUB_REF"])
492+
if not os.environ.get("RH_REPOSITORY"):
493+
os.environ["RH_REPOSITORY"] = os.environ["GITHUB_REPOSITORY"]
494+
if not os.environ.get("RH_REF"):
495+
os.environ["RH_REF"] = os.environ["GITHUB_REF"]
484496

485497
check_release = os.environ.get("RH_IS_CHECK_RELEASE", "").lower() == "true"
486498
if not os.environ.get("RH_DRY_RUN") and check_release:
@@ -509,7 +521,8 @@ def prepare_environment():
509521

510522
# Set up GitHub object.
511523
branch = os.environ.get("RH_BRANCH")
512-
owner, repo_name = os.environ["GITHUB_REPOSITORY"].split("/")
524+
log(f"Getting GitHub connection for {os.environ['RH_REPOSITORY']}")
525+
owner, repo_name = os.environ["RH_REPOSITORY"].split("/")
513526
auth = os.environ.get("GITHUB_ACCESS_TOKEN", "")
514527
gh = get_gh_object(dry_run=dry_run, owner=owner, repo=repo_name, token=auth)
515528

@@ -526,6 +539,7 @@ def prepare_environment():
526539

527540
# Extract the metadata from the release url.
528541
return extract_metadata_from_release_url(gh, release_url, auth)
542+
return release_url
529543

530544

531545
def handle_since():

0 commit comments

Comments
 (0)