Skip to content

Commit 71a8bd6

Browse files
authored
Clean up handling of draft release metadata (#387)
1 parent 7436386 commit 71a8bd6

File tree

2 files changed

+24
-18
lines changed

2 files changed

+24
-18
lines changed

jupyter_releaser/cli.py

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,32 +57,48 @@ def invoke(self, ctx):
5757

5858
# Print a separation header
5959
util.log(f'\n\n{"-" * 50}')
60-
util.log(cmd_name)
61-
util.log(f'{"-" * 50}\n\n')
60+
util.log(f"\n{cmd_name}\n")
6261

6362
if cmd_name in skip or cmd_name.replace("-", "_") in skip:
6463
util.log("*** Skipping based on skip config")
64+
util.log(f'{"-" * 50}\n\n')
6565
return
6666

6767
# Handle all of the parameters
6868
for param in self.commands[cmd_name].get_params(ctx):
69+
name = param.name
70+
assert name is not None
71+
6972
# Defer to env var overrides
7073
if param.envvar and os.environ.get(str(param.envvar)):
74+
value = os.environ[str(param.envvar)]
75+
if "token" in name.lower():
76+
value = "***"
77+
util.log(f"Using env value for {name}: {value}")
7178
continue
72-
name = param.name
73-
assert name is not None
79+
80+
# Handle cli and options overrides.
7481
if name in options or name.replace("_", "-") in options:
7582
arg = f"--{name.replace('_', '-')}"
7683
# Defer to cli overrides
7784
if arg not in ctx.args:
7885
val = options.get(name, options.get(name.replace("_", "-")))
86+
util.log(f"Adding option override for {arg}")
7987
if isinstance(val, list):
8088
for v in val:
8189
ctx.args.append(arg)
8290
ctx.args.append(v)
8391
else:
8492
ctx.args.append(arg)
8593
ctx.args.append(val)
94+
continue
95+
else:
96+
util.log(f"Using cli arg for {name}")
97+
continue
98+
99+
util.log(f"Using default value for {name}")
100+
101+
util.log(f'{"-" * 50}\n\n')
86102

87103
# Handle before hooks
88104
before = f"before-{cmd_name}"

jupyter_releaser/util.py

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -470,20 +470,10 @@ def extract_metadata_from_release_url(gh, release_url, auth):
470470
)
471471

472472
# Update environment variables.
473-
if "post_version_spec" in data:
474-
os.environ["RH_POST_VERSION_SPEC"] = data["post_version_spec"]
475-
if "post_version_message" in data:
476-
os.environ["RH_POST_VERSION_MESSAGE"] = data["post_version_message"]
477-
if "version_spec" in data:
478-
os.environ["RH_VERSION_SPEC"] = data["version_spec"]
479-
if "branch" in data:
480-
os.environ["RH_BRANCH"] = data["branch"]
481-
if "since" in data:
482-
os.environ["RH_SINCE"] = data["since"]
483-
if "ref" in data:
484-
os.environ["RH_REF"] = data["ref"]
485-
if "since_last_stable" in data:
486-
os.environ["RH_SINCE_LAST_STABLE"] = str(data["since_last_stable"])
473+
for key, value in data.items():
474+
if value is not None:
475+
env_name = f"RH_{key.upper()}"
476+
os.environ[env_name] = str(value)
487477

488478
return data
489479

0 commit comments

Comments
 (0)