Add more default python dist checks (#481)

Author: blink1073

.github/workflows/test.yml

@@ -73,7 +73,7 @@ jobs:
         run: |
           set -eux
           pip install -e .
-          python -m jupyter_releaser.actions.generate-changelog
+          python -m jupyter_releaser.actions.generate_changelog
           cat CHANGELOG_ENTRY.md
           # Check for version entry contents
           cat CHANGELOG_ENTRY.md | grep -q "#234"
@@ -84,7 +84,7 @@ jobs:
           export RH_CONVERT_TO_RST=true
           sudo apt-get install pandoc
           pip install pypandoc
-          python -m jupyter_releaser.actions.generate-changelog
+          python -m jupyter_releaser.actions.generate_changelog
           cat CHANGELOG_ENTRY.md
 
   test_minimum_versions:

jupyter_releaser/actions/generate-changelog.py renamed to jupyter_releaser/actions/generate_changelog.py

@@ -289,9 +289,19 @@ def main(force):
     click.option(
         "--pydist-check-cmd",
         envvar="RH_PYDIST_CHECK_CMD",
-        default="pipx run twine check --strict",
+        default="pipx run twine check --strict {dist_file}",
         help="The command to use to check a python distribution file",
     ),
+    click.option(
+        "--pydist-extra-check-cmds",
+        envvar="RH_EXTRA_PYDIST_CHECK_CMDS",
+        default=[
+            "pipx run 'validate-pyproject[all]' pyproject.toml",
+            "pipx run check-wheel-contents --ignore W002 {dist_dir}",
+        ],
+        multiple=True,
+        help="Extra checks to run against the pydist file",
+    ),
     click.option(
         "--pydist-resource-paths",
         envvar="RH_PYDIST_RESOURCE_PATHS",
@@ -446,7 +456,9 @@ def build_python(dist_dir, python_packages):
 @add_options(check_imports_options)
 @add_options(pydist_check_options)
 @use_checkout_dir()
-def check_python(dist_dir, check_imports, pydist_check_cmd, pydist_resource_paths):
+def check_python(
+    dist_dir, check_imports, pydist_check_cmd, pydist_extra_check_cmds, pydist_resource_paths
+):
     """Check Python dist files"""
     for dist_file in glob(f"{dist_dir}/*"):
         if Path(dist_file).suffix not in [".gz", ".whl"]:
@@ -457,6 +469,7 @@ def check_python(dist_dir, check_imports, pydist_check_cmd, pydist_resource_path
             dist_file,
             python_imports=check_imports,
             check_cmd=pydist_check_cmd,
+            extra_check_cmds=pydist_extra_check_cmds,
             resource_paths=pydist_resource_paths,
         )
 

jupyter_releaser/cli.py

@@ -32,13 +32,17 @@ def check_dist(
     dist_file,
     test_cmd="",
     python_imports=None,
-    check_cmd="pipx twine check --strict",
+    check_cmd="pipx run twine check --strict {dist_file}",
+    extra_check_cmds=None,
     resource_paths=None,
 ):
     """Check a Python package locally (not as a cli)"""
     resource_paths = resource_paths or []
     dist_file = util.normalize_path(dist_file)
-    util.run(f"{check_cmd} {dist_file}")
+    dist_dir = os.path.dirname(dist_file)  # used for check cmds.
+
+    for cmd in [check_cmd] + list(extra_check_cmds or []):
+        util.run(cmd.format(**locals()))
 
     test_commands = []
 

jupyter_releaser/python.py

@@ -147,7 +147,11 @@ def run(args: Union[str, List[str]], **kwargs: Any) -> CompletedProcess:
 
     check = kwargs.get("check", False)
 
-    loop = asyncio.get_event_loop_policy().get_event_loop()
+    try:
+        loop = asyncio.get_event_loop()
+    except Exception:
+        loop = asyncio.new_event_loop()
+        asyncio.set_event_loop(loop)
     result = loop.run_until_complete(_stream_subprocess(cmd, **kwargs))
     atexit.register(loop.close)
 

jupyter_releaser/tee.py

@@ -156,6 +156,7 @@ def test_list_envvars(runner):
 post-version-message: RH_POST_VERSION_MESSAGE
 post-version-spec: RH_POST_VERSION_SPEC
 pydist-check-cmd: RH_PYDIST_CHECK_CMD
+pydist-extra-check-cmds: RH_EXTRA_PYDIST_CHECK_CMDS
 pydist-resource-paths: RH_PYDIST_RESOURCE_PATHS
 python-packages: RH_PYTHON_PACKAGES
 ref: RH_REF