CI Cleanup (#462)

Author: blink1073

.github/workflows/test.yml

@@ -12,28 +12,14 @@ env:
   PYTHONDONTWRITEBYTECODE: 1
 
 jobs:
-  # Run "pre-commit run --all-files --hook-stage=manual"
-  pre-commit:
-    runs-on: ubuntu-20.04
-    timeout-minutes: 5
+  pre_commit:
+    runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
-      - uses: pre-commit/[email protected]
-        with:
-          extra_args: --all-files --hook-stage=manual
-      - name: Help message if pre-commit fail
-        if: ${{ failure() }}
-        run: |
-          echo "You can install pre-commit hooks to automatically run formatting"
-          echo "on each commit with:"
-          echo "    pre-commit install"
-          echo "or you can run by hand on staged files with"
-          echo "    pre-commit run"
-          echo "or after-the-fact on already committed files with"
-          echo "    pre-commit run --all-files --hook-stage=manual"
-
-  check-links:
+      - uses: jupyterlab/maintainer-tools/.github/actions/pre-commit@v1
+
+  check_links:
     runs-on: ubuntu-20.04
     steps:
       - uses: actions/checkout@v2
@@ -54,15 +40,15 @@ jobs:
       - name: Run the tests with coverage on Ubuntu
         if: ${{ matrix.os == 'ubuntu-latest' }}
         run: |
-          hatch run cov:test -n auto || hatch run test:test --lf
+          hatch run cov:test -n auto --cov-fail-under 80 || hatch run test:test --lf
           pip install codecov
           codecov
 
       - name: Run the tests on Windows and MacOS
         if: ${{ matrix.os != 'ubuntu-latest' }}
-        run: hatch run test:test -s -n auto || hatch run test:test -s --lf
+        run: hatch run cov:test -s -n auto || hatch run cov:test -s --lf
 
-  generate-changelog:
+  generate_changelog:
     runs-on: ubuntu-20.04
     timeout-minutes: 10
     steps:
@@ -90,6 +76,37 @@ jobs:
           python -m jupyter_releaser.actions.generate-changelog
           cat CHANGELOG_ENTRY.md
 
+  test_minimum_versions:
+    name: Test Minimum Versions
+    timeout-minutes: 20
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
+        with:
+          python_version: "3.8"
+      - uses: jupyterlab/maintainer-tools/.github/actions/install-minimums@v1
+        with:
+          only_create_file: 1
+      - name: Run the unit tests
+        run: |
+          export PIP_CONSTRAINT="./contraints_file.txt"
+          hatch run test:nowarn || hatch run test:nowarn --lf
+
+  test_prereleases:
+    name: Test Prereleases
+    runs-on: ubuntu-latest
+    timeout-minutes: 20
+    steps:
+      - uses: actions/checkout@v3
+      - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
+        with:
+          python_version: "3.11"
+      - name: Run the tests
+        run: |
+          export PIP_PRE=1
+          hatch run test:nowarn || hatch run test:nowarn --lf
+
   docs:
     runs-on: ubuntu-20.04
     timeout-minutes: 10
@@ -127,12 +144,14 @@ jobs:
   check: # This job does nothing and is only used for the branch protection
     if: always()
     needs:
-      - check-links
+      - check_links
       - test
       - docs
-      - pre-commit
+      - pre_commit
       - check_local_actions
-      - generate-changelog
+      - test_minimum_versions
+      - test_prereleases
+      - generate_changelog
     runs-on: ubuntu-latest
     steps:
       - name: Decide whether the needed jobs succeeded or failed

.pre-commit-config.yaml

@@ -72,22 +72,18 @@ repos:
           ]
         stages: [manual]
 
-  - repo: https://github.com/sirosen/check-jsonschema
+  - repo: https://github.com/python-jsonschema/check-jsonschema
     rev: 0.19.1
     hooks:
-      - id: check-jsonschema
+      - id: check-github-workflows
         name: "Check GitHub Workflows"
         files: ^\.github/workflows/
         types: [yaml]
-        args: ["--schemafile", "https://json.schemastore.org/github-workflow"]
-        stages: [manual]
 
-  - repo: https://github.com/sirosen/check-jsonschema
+  - repo: https://github.com/python-jsonschema/check-jsonschema
     rev: 0.19.1
     hooks:
-      - id: check-jsonschema
+      - id: check-github-workflows
         name: "Check Example Workflows"
         files: ^example-workflows/
         types: [yaml]
-        args: ["--schemafile", "https://json.schemastore.org/github-workflow"]
-        stages: [manual]

codecov.yml

@@ -3,7 +3,7 @@ coverage:
     project:
       default:
         target: auto
-        threshold: 10
+        threshold: 1
     patch:
       default:
         target: 0%

jupyter_releaser/tests/conftest.py

@@ -29,8 +29,8 @@ def github_port(worker_id):
 @fixture(autouse=True)
 def mock_env(mocker):
     """Clear unwanted environment variables"""
-    # Anything that starts with RH_ or GITHUB_
-    prefixes = ["GITHUB_", "RH_"]
+    # Anything that starts with RH_ or GITHUB_ or PIP
+    prefixes = ["GITHUB_", "RH_", "PIP_"]
     env = os.environ.copy()
     for key in list(env):
         for prefix in prefixes:

pyproject.toml

@@ -79,15 +79,14 @@ build = "make -C docs html SPHINXOPTS='-W'"
 features = ["test"]
 [tool.hatch.envs.test.scripts]
 test = "python -m pytest -vv {args}"
-nowarn = "python -m pytest -vv -W default {args}"
+nowarn = "test -W default {args}"
 
 [tool.hatch.envs.cov]
 features = ["test"]
 dependencies = ["coverage", "pytest-cov"]
-[tool.hatch.envs.cov.env-vars]
-ARGS = "-vv --cov jupyter_releaser --cov-branch --cov-report term-missing:skip-covered"
 [tool.hatch.envs.cov.scripts]
-test = "python -m pytest $ARGS --cov-fail-under 80 {args}"
+test = "python -m pytest -vv --cov jupyter_releaser --cov-branch --cov-report term-missing:skip-covered {args}"
+nowarn = "test -W default {args}"
 
 [tool.jupyter-releaser.hooks]
 after-populate-release = "bash ./.github/scripts/bump_tag.sh"
@@ -107,6 +106,20 @@ filterwarnings= [
   "module:Neither GITHUB_TOKEN nor GITHUB_JWT_TOKEN found:UserWarning",
 ]
 
+[tool.coverage.report]
+exclude_lines = [
+  "pragma: no cover",
+  "def __repr__",
+  "if self.debug:",
+  "if settings.DEBUG",
+  "raise AssertionError",
+  "raise NotImplementedError",
+  "if 0:",
+  "if __name__ == .__main__.:",
+  "class .*\bProtocol\\):",
+"@(abc\\.)?abstractmethod",
+]
+
 [tool.mypy]
 check_untyped_defs = true
 disallow_any_generics = false