Skip to content

Commit a020e84

Browse files
author
Steven Silvester
committed
even more cleanup
1 parent 6598291 commit a020e84

File tree

5 files changed

+8
-5
lines changed

5 files changed

+8
-5
lines changed

.github/workflows/check-release.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ on:
44
branches: ["*"]
55
pull_request:
66
branches: ["*"]
7+
schedule:
8+
- cron: "0 0 * * *"
79

810
jobs:
911
check_release:

jupyter_releaser/actions/draft_release.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@
55
run("jupyter-releaser prep-git")
66
run("jupyter-releaser bump-version")
77
run("jupyter-releaser check-changelog")
8-
run("jupyter-releaser check-links")
98
# Make sure npm comes before python in case it produces
109
# files for the python package
1110
run("jupyter-releaser build-npm")
1211
run("jupyter-releaser check-npm")
1312
run("jupyter-releaser build-python")
1413
run("jupyter-releaser check-python")
1514
run("jupyter-releaser check-manifest")
15+
run("jupyter-releaser check-links")
1616
run("jupyter-releaser tag-release")
1717
run("jupyter-releaser draft-release")

jupyter_releaser/lib.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def check_links(ignore_glob, ignore_links, cache_file, links_expire):
6565
for spec in ignore_links:
6666
cmd += f' --check-links-ignore "{spec}"'
6767

68-
cmd += " --ignore node_modules"
68+
cmd += " --ignore-glob node_modules"
6969

7070
# Gather all of the markdown, RST, and ipynb files
7171
files = []
@@ -369,7 +369,7 @@ def publish_assets(dist_dir, npm_token, npm_cmd, twine_cmd, dry_run, use_checkou
369369
npm.handle_npm_config(npm_token, dist_dir)
370370

371371
found = False
372-
for path in glob(f"{dist_dir}/*.*"):
372+
for path in sorted(glob(f"{dist_dir}/*.*")):
373373
name = Path(path).name
374374
suffix = Path(path).suffix
375375
if suffix in [".gz", ".whl"]:

jupyter_releaser/util.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,8 @@ def create_release_commit(version, dist_dir="dist"):
145145
path = normalize_path(path)
146146
sha256 = compute_sha256(path)
147147
shas[path] = sha256
148-
cmd += f' -m "{path}: {sha256}"'
148+
name = osp.basename(path)
149+
cmd += f' -m "{name}: {sha256}"'
149150

150151
run(cmd)
151152

setup.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ install_requires =
3737
pytest-check-links>=0.5
3838
requests
3939
requests_cache
40-
setuptools
40+
setuptools~=57.0
4141
tomlkit==0.7.0
4242
tbump==6.3.2
4343
toml==0.10.2

0 commit comments

Comments
 (0)