Skip to content

Commit a48f996

Browse files
committed
forward python imports for checking with extract_release
1 parent 54ee402 commit a48f996

File tree

2 files changed

+27
-4
lines changed

2 files changed

+27
-4
lines changed

jupyter_releaser/cli.py

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -600,13 +600,26 @@ def delete_release(auth, release_url):
600600
@add_options(dry_run_options)
601601
@add_options(npm_install_options)
602602
@add_options(pydist_check_options)
603+
@add_options(check_imports_options)
603604
@click.argument("release-url", nargs=1)
604605
def extract_release(
605-
auth, dist_dir, dry_run, release_url, npm_install_options, pydist_check_cmd
606+
auth,
607+
dist_dir,
608+
dry_run,
609+
release_url,
610+
npm_install_options,
611+
pydist_check_cmd,
612+
check_imports,
606613
):
607614
"""Download and verify assets from a draft GitHub release"""
608615
lib.extract_release(
609-
auth, dist_dir, dry_run, release_url, npm_install_options, pydist_check_cmd
616+
auth,
617+
dist_dir,
618+
dry_run,
619+
release_url,
620+
npm_install_options,
621+
pydist_check_cmd,
622+
check_imports,
610623
)
611624

612625

jupyter_releaser/lib.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,13 @@ def delete_release(auth, release_url):
292292

293293

294294
def extract_release(
295-
auth, dist_dir, dry_run, release_url, npm_install_options, pydist_check_cmd
295+
auth,
296+
dist_dir,
297+
dry_run,
298+
release_url,
299+
npm_install_options,
300+
pydist_check_cmd,
301+
python_imports,
296302
):
297303
"""Download and verify assets from a draft GitHub release"""
298304
match = parse_release_url(release_url)
@@ -338,7 +344,11 @@ def extract_release(
338344
for asset in assets:
339345
suffix = Path(asset.name).suffix
340346
if suffix in [".gz", ".whl"]:
341-
python.check_dist(dist / asset.name, check_cmd=pydist_check_cmd)
347+
python.check_dist(
348+
dist / asset.name,
349+
check_cmd=pydist_check_cmd,
350+
python_imports=python_imports,
351+
)
342352
elif suffix == ".tgz":
343353
pass # already handled
344354
else:

0 commit comments

Comments
 (0)