Skip to content

Commit e8dd7b6

Browse files
authored
Clean up workflows (#379)
1 parent a30d0d2 commit e8dd7b6

File tree

3 files changed

+16
-14
lines changed

3 files changed

+16
-14
lines changed

.github/actions/draft-changelog/action.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,19 @@ inputs:
44
token:
55
description: "GitHub access token"
66
required: true
7+
target:
8+
description: "The owner/repo GitHub target"
9+
required: true
710
version_spec:
811
description: "New Version Specifier"
912
default: "next"
1013
required: false
11-
post_version_spec:
12-
description: "Post Version Specifier"
13-
required: false
14-
target:
15-
description: "The owner/repo GitHub target"
16-
required: true
1714
branch:
1815
description: "The branch to target"
1916
required: false
17+
post_version_spec:
18+
description: "Post Version Specifier"
19+
required: false
2020
dry_run:
2121
description: "If set, do not make a PR"
2222
default: "false"
@@ -33,7 +33,7 @@ outputs:
3333
value: ${{ steps.draft-changelog.outputs.pr_url }}
3434
release_url:
3535
description: "The html URL of the draft GitHub release"
36-
value: ${{ steps.draft-release.outputs.release_url }}
36+
value: ${{ steps.draft-changelog.outputs.release_url }}
3737
runs:
3838
using: "composite"
3939
steps:

.github/workflows/draft-changelog.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,19 @@ name: "Step 1: Draft Changelog"
22
on:
33
workflow_dispatch:
44
inputs:
5-
version_spec:
6-
description: "New Version Specifier"
7-
required: true
8-
post_version_spec:
9-
description: "Post Version Specifier"
10-
required: false
115
target:
126
description: "The owner/repo GitHub target"
137
required: true
8+
version_spec:
9+
description: "New Version Specifier"
10+
default: "next"
11+
required: false
1412
branch:
1513
description: "The branch to target"
1614
required: false
15+
post_version_spec:
16+
description: "Post Version Specifier"
17+
required: false
1718
since:
1819
description: "Use PRs with activity since this date or git reference"
1920
required: false

jupyter_releaser/lib.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,8 @@ def draft_release(
318318
gh.upload_file(release, fpath)
319319

320320
# Set the body of the release with the changelog contents.
321-
gh.repos.update_release(
321+
# Get the new release since the draft release might change urls.
322+
release = gh.repos.update_release(
322323
release.id,
323324
release.tag_name,
324325
release.target_commitish,

0 commit comments

Comments
 (0)