Skip to content

Commit 1060b32

Browse files
authored
Merge pull request #303 from Zsailer/broken-extensions
Handing broken extensions
2 parents 3683aa4 + 0f105ae commit 1060b32

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

jupyter_server/extension/manager.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,12 +275,17 @@ def from_jpserver_extensions(self, jpserver_extensions):
275275
self.add_extension(name, enabled=enabled)
276276

277277
def add_extension(self, extension_name, enabled=False):
278+
"""Try to add extension to manager, return True if successful.
279+
Otherwise, return False.
280+
"""
278281
try:
279282
extpkg = ExtensionPackage(name=extension_name, enabled=enabled)
280283
self._extensions[extension_name] = extpkg
284+
return True
281285
# Raise a warning if the extension cannot be loaded.
282286
except Exception as e:
283287
self.log.warning(e)
288+
return False
284289

285290
def link_extension(self, name, serverapp):
286291
linked = self._linked_extensions.get(name, False)
@@ -320,4 +325,3 @@ def load_all_extensions(self, serverapp):
320325
# order.
321326
for name in sorted(self.extensions.keys()):
322327
self.load_extension(name, serverapp)
323-

0 commit comments

Comments
 (0)