Skip to content

Commit 1200ffb

Browse files
committed
Address code analysis issues
1 parent 992d7ae commit 1200ffb

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

jupyter_server/gateway/gateway_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ def validate_cert_default(self):
197197
return bool(os.environ.get(self.validate_cert_env, str(self.validate_cert_default_value)) not in ['no', 'false'])
198198

199199
def __init__(self, **kwargs):
200-
super(GatewayClient, self).__init__(**kwargs)
200+
super().__init__(**kwargs)
201201
self._static_args = {} # initialized on first use
202202

203203
env_whitelist_default_value = ''

jupyter_server/gateway/managers.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
from threading import Thread
1818
from tornado import web
1919
from tornado.escape import json_encode, json_decode, url_escape, utf8
20-
from tornado.httpclient import HTTPClient, HTTPError
2120
from traitlets import Instance, DottedObjectName, Type, default
2221
from typing import Dict
2322

@@ -43,7 +42,7 @@ def _default_shared_context(self):
4342
return False # no need to share zmq contexts
4443

4544
def __init__(self, **kwargs):
46-
super(GatewayKernelManagers, self).__init__(**kwargs)
45+
super().__init__(**kwargs)
4746
self.kernels_url = url_path_join(GatewayClient.instance().url, GatewayClient.instance().kernels_endpoint)
4847

4948
def remove_kernel(self, kernel_id):
@@ -179,7 +178,7 @@ async def cull_kernels(self):
179178
class GatewayKernelSpecManager(KernelSpecManager):
180179

181180
def __init__(self, **kwargs):
182-
super(GatewayKernelSpecManager, self).__init__(**kwargs)
181+
super().__init__(**kwargs)
183182
base_endpoint = url_path_join(GatewayClient.instance().url,
184183
GatewayClient.instance().kernelspecs_endpoint)
185184

@@ -291,7 +290,7 @@ async def kernel_culled(self, kernel_id):
291290
try:
292291
km = self.kernel_manager.get_kernel(kernel_id)
293292
kernel = await km.refresh_model()
294-
except Exception:
293+
except Exception: # Let exceptions here reflect culled kernel
295294
pass
296295
return kernel is None
297296

@@ -494,6 +493,7 @@ def send(self, msg: dict) -> None:
494493
def serialize_datetime(dt):
495494
if isinstance(dt, (datetime.date, datetime.datetime)):
496495
return dt.timestamp()
496+
return None
497497

498498
def start(self) -> None:
499499
pass
@@ -548,7 +548,7 @@ class GatewayKernelClient(AsyncKernelClient):
548548
_channel_queues = {}
549549

550550
def __init__(self, **kwargs):
551-
super(GatewayKernelClient, self).__init__(**kwargs)
551+
super().__init__(**kwargs)
552552
self.kernel_id = kwargs['kernel_id']
553553
self.channel_socket = None
554554
self.response_router = None

0 commit comments

Comments
 (0)