Skip to content

Commit 15417ff

Browse files
authored
init_httpserver at the end of initialize (#517)
init_httpserver references IOLoop.current() If a server extension sets an asyncio EventLoopPolicy, any prior reference to IOLoop.current or asyncio.get_event_loop() will be invalidated. We should try to avoid this during intialize at all, or at least until the very end. Arguably, the http server listen should occur in `.start()`
1 parent f5b3b2d commit 15417ff

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

jupyter_server/serverapp.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1864,13 +1864,13 @@ def initialize(self, argv=None, find_extensions=True, new_httpserver=True, start
18641864
self.init_configurables()
18651865
self.init_components()
18661866
self.init_webapp()
1867-
if new_httpserver:
1868-
self.init_httpserver()
18691867
self.init_terminals()
18701868
self.init_signal()
18711869
self.load_server_extensions()
18721870
self.init_mime_overrides()
18731871
self.init_shutdown_no_activity()
1872+
if new_httpserver:
1873+
self.init_httpserver()
18741874

18751875
def cleanup_kernels(self):
18761876
"""Shutdown all kernels.

0 commit comments

Comments
 (0)