Skip to content

Commit 1863fde

Browse files
authored
Fix jupyter_client warning (#581)
1 parent 836b5ab commit 1863fde

File tree

4 files changed

+33
-19
lines changed

4 files changed

+33
-19
lines changed

jupyter_server/base/zmqhandlers.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@
99

1010
import tornado
1111
from ipython_genutils.py3compat import cast_unicode
12-
from jupyter_client.jsonutil import date_default
12+
13+
try:
14+
from jupyter_client.jsonutil import json_default
15+
except ImportError:
16+
from jupyter_client.jsonutil import date_default as json_default
1317
from jupyter_client.jsonutil import extract_dates
1418
from jupyter_client.session import Session
1519
from tornado import ioloop
@@ -39,7 +43,7 @@ def serialize_binary_message(msg):
3943
buffers = list(msg.pop("buffers"))
4044
if sys.version_info < (3, 4):
4145
buffers = [x.tobytes() for x in buffers]
42-
bmsg = json.dumps(msg, default=date_default).encode("utf8")
46+
bmsg = json.dumps(msg, default=json_default).encode("utf8")
4347
buffers.insert(0, bmsg)
4448
nbufs = len(buffers)
4549
offsets = [4 * (nbufs + 1)]
@@ -227,7 +231,7 @@ def _reserialize_reply(self, msg_or_list, channel=None):
227231
buf = serialize_binary_message(msg)
228232
return buf
229233
else:
230-
smsg = json.dumps(msg, default=date_default)
234+
smsg = json.dumps(msg, default=json_default)
231235
return cast_unicode(smsg)
232236

233237
def _on_zmq_reply(self, stream, msg_list):

jupyter_server/services/contents/handlers.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@
66
# Distributed under the terms of the Modified BSD License.
77
import json
88

9-
from jupyter_client.jsonutil import date_default
9+
try:
10+
from jupyter_client.jsonutil import json_default
11+
except ImportError:
12+
from jupyter_client.jsonutil import date_default as json_default
1013
from tornado import web
1114

1215
from jupyter_server.base.handlers import APIHandler
@@ -77,7 +80,7 @@ def _finish_model(self, model, location=True):
7780
self.set_header("Location", location)
7881
self.set_header("Last-Modified", model["last_modified"])
7982
self.set_header("Content-Type", "application/json")
80-
self.finish(json.dumps(model, default=date_default))
83+
self.finish(json.dumps(model, default=json_default))
8184

8285
@web.authenticated
8386
async def get(self, path=""):
@@ -237,15 +240,15 @@ async def get(self, path=""):
237240
"""get lists checkpoints for a file"""
238241
cm = self.contents_manager
239242
checkpoints = await ensure_async(cm.list_checkpoints(path))
240-
data = json.dumps(checkpoints, default=date_default)
243+
data = json.dumps(checkpoints, default=json_default)
241244
self.finish(data)
242245

243246
@web.authenticated
244247
async def post(self, path=""):
245248
"""post creates a new checkpoint"""
246249
cm = self.contents_manager
247250
checkpoint = await ensure_async(cm.create_checkpoint(path))
248-
data = json.dumps(checkpoint, default=date_default)
251+
data = json.dumps(checkpoint, default=json_default)
249252
location = url_path_join(
250253
self.base_url,
251254
"api/contents",

jupyter_server/services/kernels/handlers.py

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,11 @@
1010

1111
from ipython_genutils.py3compat import cast_unicode
1212
from jupyter_client import protocol_version as client_protocol_version
13-
from jupyter_client.jsonutil import date_default
13+
14+
try:
15+
from jupyter_client.jsonutil import json_default
16+
except ImportError:
17+
from jupyter_client.jsonutil import date_default as json_default
1418
from tornado import gen
1519
from tornado import web
1620
from tornado.concurrent import Future
@@ -29,7 +33,7 @@ class MainKernelHandler(APIHandler):
2933
async def get(self):
3034
km = self.kernel_manager
3135
kernels = await ensure_async(km.list_kernels())
32-
self.finish(json.dumps(kernels, default=date_default))
36+
self.finish(json.dumps(kernels, default=json_default))
3337

3438
@web.authenticated
3539
async def post(self):
@@ -45,15 +49,15 @@ async def post(self):
4549
location = url_path_join(self.base_url, "api", "kernels", url_escape(kernel_id))
4650
self.set_header("Location", location)
4751
self.set_status(201)
48-
self.finish(json.dumps(model, default=date_default))
52+
self.finish(json.dumps(model, default=json_default))
4953

5054

5155
class KernelHandler(APIHandler):
5256
@web.authenticated
5357
async def get(self, kernel_id):
5458
km = self.kernel_manager
5559
model = await ensure_async(km.kernel_model(kernel_id))
56-
self.finish(json.dumps(model, default=date_default))
60+
self.finish(json.dumps(model, default=json_default))
5761

5862
@web.authenticated
5963
async def delete(self, kernel_id):
@@ -79,7 +83,7 @@ async def post(self, kernel_id, action):
7983
self.set_status(500)
8084
else:
8185
model = await ensure_async(km.kernel_model(kernel_id))
82-
self.write(json.dumps(model, default=date_default))
86+
self.write(json.dumps(model, default=json_default))
8387
self.finish()
8488

8589

@@ -443,7 +447,7 @@ def write_stderr(error_message):
443447
"stream", content={"text": error_message + "\n", "name": "stderr"}, parent=parent
444448
)
445449
msg["channel"] = "iopub"
446-
self.write_message(json.dumps(msg, default=date_default))
450+
self.write_message(json.dumps(msg, default=json_default))
447451

448452
channel = getattr(stream, "channel", None)
449453
msg_type = msg["header"]["msg_type"]
@@ -610,7 +614,7 @@ def _send_status_message(self, status):
610614
iopub.flush()
611615
msg = self.session.msg("status", {"execution_state": status})
612616
msg["channel"] = "iopub"
613-
self.write_message(json.dumps(msg, default=date_default))
617+
self.write_message(json.dumps(msg, default=json_default))
614618

615619
def on_kernel_restarted(self):
616620
logging.warn("kernel %s restarted", self.kernel_id)

jupyter_server/services/sessions/handlers.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@
66
# Distributed under the terms of the Modified BSD License.
77
import json
88

9-
from jupyter_client.jsonutil import date_default
9+
try:
10+
from jupyter_client.jsonutil import json_default
11+
except ImportError:
12+
from jupyter_client.jsonutil import date_default as json_default
1013
from jupyter_client.kernelspec import NoSuchKernel
1114
from tornado import web
1215

@@ -21,7 +24,7 @@ async def get(self):
2124
# Return a list of running sessions
2225
sm = self.session_manager
2326
sessions = await ensure_async(sm.list_sessions())
24-
self.finish(json.dumps(sessions, default=date_default))
27+
self.finish(json.dumps(sessions, default=json_default))
2528

2629
@web.authenticated
2730
async def post(self):
@@ -79,7 +82,7 @@ async def post(self):
7982
location = url_path_join(self.base_url, "api", "sessions", model["id"])
8083
self.set_header("Location", location)
8184
self.set_status(201)
82-
self.finish(json.dumps(model, default=date_default))
85+
self.finish(json.dumps(model, default=json_default))
8386

8487

8588
class SessionHandler(APIHandler):
@@ -88,7 +91,7 @@ async def get(self, session_id):
8891
# Returns the JSON model for a single session
8992
sm = self.session_manager
9093
model = await sm.get_session(session_id=session_id)
91-
self.finish(json.dumps(model, default=date_default))
94+
self.finish(json.dumps(model, default=json_default))
9295

9396
@web.authenticated
9497
async def patch(self, session_id):
@@ -142,7 +145,7 @@ async def patch(self, session_id):
142145
# kernel_id changed because we got a new kernel
143146
# shutdown the old one
144147
await ensure_async(km.shutdown_kernel(before["kernel"]["id"]))
145-
self.finish(json.dumps(model, default=date_default))
148+
self.finish(json.dumps(model, default=json_default))
146149

147150
@web.authenticated
148151
async def delete(self, session_id):

0 commit comments

Comments
 (0)