Skip to content

Commit 1cb4116

Browse files
[pre-commit.ci] pre-commit autoupdate (#1322)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Steven Silvester <[email protected]>
1 parent a7b033d commit 1cb4116

File tree

18 files changed

+54
-86
lines changed

18 files changed

+54
-86
lines changed

.pre-commit-config.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,22 +20,22 @@ repos:
2020
- id: trailing-whitespace
2121

2222
- repo: https://github.com/python-jsonschema/check-jsonschema
23-
rev: 0.23.2
23+
rev: 0.26.3
2424
hooks:
2525
- id: check-github-workflows
2626

2727
- repo: https://github.com/executablebooks/mdformat
28-
rev: 0.7.16
28+
rev: 0.7.17
2929
hooks:
3030
- id: mdformat
3131

3232
- repo: https://github.com/psf/black
33-
rev: 23.3.0
33+
rev: 23.7.0
3434
hooks:
3535
- id: black
3636

3737
- repo: https://github.com/astral-sh/ruff-pre-commit
38-
rev: v0.0.276
38+
rev: v0.0.287
3939
hooks:
4040
- id: ruff
4141
args: ["--fix"]

jupyter_server/base/handlers.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -403,10 +403,7 @@ def set_attachment_header(self, filename):
403403
escaped_filename = url_escape(filename)
404404
self.set_header(
405405
"Content-Disposition",
406-
"attachment;"
407-
" filename*=utf-8''{utf8}".format(
408-
utf8=escaped_filename,
409-
),
406+
f"attachment; filename*=utf-8''{escaped_filename}",
410407
)
411408

412409
def get_origin(self):

jupyter_server/extension/application.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -608,10 +608,7 @@ def launch_instance(cls, argv=None, **kwargs):
608608

609609
# Log if extension is blocking other extensions from loading.
610610
if not cls.load_other_extensions:
611-
serverapp.log.info(
612-
"{ext_name} is running without loading "
613-
"other extensions.".format(ext_name=cls.name)
614-
)
611+
serverapp.log.info(f"{cls.name} is running without loading other extensions.")
615612
# Start the server.
616613
try:
617614
serverapp.start()

jupyter_server/extension/utils.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,10 @@ def get_loader(obj, logger=None):
4848

4949
warnings.warn(
5050
"A `_load_jupyter_server_extension` function was not "
51-
"found in {name!s}. Instead, a `load_jupyter_server_extension` "
51+
f"found in {obj!s}. Instead, a `load_jupyter_server_extension` "
5252
"function was found and will be used for now. This function "
5353
"name will be deprecated in future releases "
54-
"of Jupyter Server.".format(name=obj),
54+
"of Jupyter Server.",
5555
DeprecationWarning,
5656
stacklevel=2,
5757
)
@@ -91,10 +91,10 @@ def get_metadata(package_name, logger=None):
9191
if logger:
9292
logger.warning(
9393
"A `_jupyter_server_extension_points` function was not "
94-
"found in {name}. Instead, a `_jupyter_server_extension_paths` "
94+
f"found in {package_name}. Instead, a `_jupyter_server_extension_paths` "
9595
"function was found and will be used for now. This function "
9696
"name will be deprecated in future releases "
97-
"of Jupyter Server.".format(name=package_name)
97+
"of Jupyter Server."
9898
)
9999
return module, extension_points
100100
except AttributeError:
@@ -105,9 +105,9 @@ def get_metadata(package_name, logger=None):
105105
if logger:
106106
logger.debug(
107107
"A `_jupyter_server_extension_points` function was "
108-
"not found in {name}, so Jupyter Server will look "
108+
f"not found in {package_name}, so Jupyter Server will look "
109109
"for extension points in the extension pacakge's "
110-
"root.".format(name=package_name)
110+
"root."
111111
)
112112
return module, [{"module": package_name, "name": package_name}]
113113

jupyter_server/gateway/connections.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,7 @@ def handle_outgoing_message(self, incoming_msg: str, *args: Any) -> None:
131131
json_decode(utf8(incoming_msg))
132132
)
133133
self.log.debug(
134-
"Notebook client closed websocket connection - message dropped: {}".format(
135-
msg_summary
136-
)
134+
f"Notebook client closed websocket connection - message dropped: {msg_summary}"
137135
)
138136

139137
def handle_incoming_message(self, message: str) -> None:

jupyter_server/gateway/gateway_client.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -526,15 +526,8 @@ def _deprecated_trait(self, change):
526526
# protects backward-compatible config from warnings
527527
# if they set the same value under both names
528528
self.log.warning(
529-
(
530-
"{cls}.{old} is deprecated in jupyter_server "
531-
"{version}, use {cls}.{new} instead"
532-
).format(
533-
cls=self.__class__.__name__,
534-
old=old_attr,
535-
new=new_attr,
536-
version=version,
537-
)
529+
f"{self.__class__.__name__}.{old_attr} is deprecated in jupyter_server "
530+
f"{version}, use {self.__class__.__name__}.{new_attr} instead"
538531
)
539532
setattr(self, new_attr, change.new)
540533

@@ -578,7 +571,7 @@ def init_connection_args(self):
578571
os.environ["KERNEL_LAUNCH_TIMEOUT"] = str(GatewayClient.KERNEL_LAUNCH_TIMEOUT)
579572

580573
self._connection_args["headers"] = json.loads(self.headers)
581-
if self.auth_header_key not in self._connection_args["headers"].keys():
574+
if self.auth_header_key not in self._connection_args["headers"]:
582575
self._connection_args["headers"].update(
583576
{f"{self.auth_header_key}": f"{self.auth_scheme} {self.auth_token}"}
584577
)

jupyter_server/gateway/handlers.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,7 @@ def write_message(self, message, binary=False):
118118
elif self.log.isEnabledFor(logging.DEBUG):
119119
msg_summary = WebSocketChannelsHandler._get_message_summary(json_decode(utf8(message)))
120120
self.log.debug(
121-
"Notebook client closed websocket connection - message dropped: {}".format(
122-
msg_summary
123-
)
121+
f"Notebook client closed websocket connection - message dropped: {msg_summary}"
124122
)
125123

126124
def on_close(self):

jupyter_server/gateway/managers.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ async def get_kernel_spec(self, kernel_name, **kwargs):
307307
try:
308308
response = await gateway_request(kernel_spec_url, method="GET")
309309
except web.HTTPError as error:
310-
if error.status_code == 404: # noqa[PLR2004]
310+
if error.status_code == 404: # noqa: PLR2004
311311
# Convert not found to KeyError since that's what the Notebook handler expects
312312
# message is not used, but might as well make it useful for troubleshooting
313313
msg = f"kernelspec {kernel_name} not found on Gateway server at: {GatewayClient.instance().url}"
@@ -336,7 +336,7 @@ async def get_kernel_spec_resource(self, kernel_name, path):
336336
try:
337337
response = await gateway_request(kernel_spec_resource_url, method="GET")
338338
except web.HTTPError as error:
339-
if error.status_code == 404: # noqa[PLR2004]
339+
if error.status_code == 404: # noqa: PLR2004
340340
kernel_spec_resource = None
341341
else:
342342
raise
@@ -433,7 +433,7 @@ async def refresh_model(self, model=None):
433433
response = await gateway_request(self.kernel_url, method="GET")
434434

435435
except web.HTTPError as error:
436-
if error.status_code == 404: # noqa[PLR2004]
436+
if error.status_code == 404: # noqa: PLR2004
437437
self.log.warning("Kernel not found at: %s" % self.kernel_url)
438438
model = None
439439
else:
@@ -527,7 +527,7 @@ async def shutdown_kernel(self, now=False, restart=False):
527527
response = await gateway_request(self.kernel_url, method="DELETE")
528528
self.log.debug("Shutdown kernel response: %d %s", response.code, response.reason)
529529
except web.HTTPError as error:
530-
if error.status_code == 404: # noqa[PLR2004]
530+
if error.status_code == 404: # noqa: PLR2004
531531
self.log.debug("Shutdown kernel response: kernel not found (ignored)")
532532
else:
533533
raise

jupyter_server/log.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,12 @@ def log_request(handler):
5555
except AttributeError:
5656
logger = access_log
5757

58-
if status < 300 or status == 304: # noqa[PLR2004]
58+
if status < 300 or status == 304: # noqa: PLR2004
5959
# Successes (or 304 FOUND) are debug-level
6060
log_method = logger.debug
61-
elif status < 400: # noqa[PLR2004]
61+
elif status < 400: # noqa: PLR2004
6262
log_method = logger.info
63-
elif status < 500: # noqa[PLR2004]
63+
elif status < 500: # noqa: PLR2004
6464
log_method = logger.warning
6565
else:
6666
log_method = logger.error
@@ -84,11 +84,11 @@ def log_request(handler):
8484
ns["username"] = username
8585

8686
msg = "{status} {method} {uri} ({username}@{ip}) {request_time:.2f}ms"
87-
if status >= 400: # noqa[PLR2004]
87+
if status >= 400: # noqa: PLR2004
8888
# log bad referers
8989
ns["referer"] = _scrub_uri(request.headers.get("Referer", "None"))
9090
msg = msg + " referer={referer}"
91-
if status >= 500 and status != 502: # noqa[PLR2004]
91+
if status >= 500 and status != 502: # noqa: PLR2004
9292
# Log a subset of the headers if it caused an error.
9393
headers = {}
9494
for header in ["Host", "Accept", "Referer", "User-Agent"]:

jupyter_server/serverapp.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ def init_settings(
311311
jenv_opt: dict = {"autoescape": True}
312312
jenv_opt.update(jinja_env_options if jinja_env_options else {})
313313

314-
env = Environment( # noqa[S701]
314+
env = Environment( # noqa: S701
315315
loader=FileSystemLoader(template_path), extensions=["jinja2.ext.i18n"], **jenv_opt
316316
)
317317
sys_info = get_sys_info()
@@ -2134,9 +2134,7 @@ def init_resources(self):
21342134
if hard < soft:
21352135
hard = soft
21362136
self.log.debug(
2137-
"Raising open file limit: soft {}->{}; hard {}->{}".format(
2138-
old_soft, soft, old_hard, hard
2139-
)
2137+
f"Raising open file limit: soft {old_soft}->{soft}; hard {old_hard}->{hard}"
21402138
)
21412139
resource.setrlimit(resource.RLIMIT_NOFILE, (soft, hard))
21422140

@@ -2631,11 +2629,7 @@ def running_server_info(self, kernel_count=True):
26312629
info += kernel_msg % n_kernels
26322630
info += "\n"
26332631
# Format the info so that the URL fits on a single line in 80 char display
2634-
info += _i18n(
2635-
"Jupyter Server {version} is running at:\n{url}".format(
2636-
version=ServerApp.version, url=self.display_url
2637-
)
2638-
)
2632+
info += _i18n(f"Jupyter Server {ServerApp.version} is running at:\n{self.display_url}")
26392633
if self.gateway_config.gateway_enabled:
26402634
info += (
26412635
_i18n("\nKernels will be managed by the Gateway server running at:\n%s")

0 commit comments

Comments
 (0)