Skip to content

Commit 3b09860

Browse files
committed
update tests to changes in metadata function
1 parent 0003ade commit 3b09860

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

jupyter_server/extension/utils.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ def get_loader(obj, logger=None):
3535
func = getattr(obj, '_load_jupyter_server_extension')
3636
except AttributeError:
3737
func = getattr(obj, 'load_jupyter_server_extension')
38-
3938
except Exception:
4039
raise ExtensionLoadingError("_load_jupyter_server_extension function was not found.")
4140
return func
@@ -54,15 +53,15 @@ def get_metadata(package_name, logger=None):
5453
module = importlib.import_module(package_name)
5554

5655
try:
57-
return module._jupyter_server_extension_points
56+
return module._jupyter_server_extension_points()
5857
except AttributeError:
5958
pass
6059

6160
# For backwards compatibility, we temporarily allow
6261
# _jupyter_server_extension_paths. We will remove in
6362
# a later release of Jupyter Server.
6463
try:
65-
return module._jupyter_server_extension_paths
64+
return module._jupyter_server_extension_paths()
6665
except AttributeError:
6766
if logger:
6867
logger.debug(

tests/extension/mockextensions/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
# Function that makes these extensions discoverable
88
# by the test functions.
9-
def _jupyter_server_extension_paths():
9+
def _jupyter_server_extension_points():
1010
return [
1111
{
1212
'module': 'tests.extension.mockextensions.app',

tests/extension/test_manager.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@
1515

1616
def test_extension_point_api():
1717
# Import mock extension metadata
18-
from .mockextensions import _jupyter_server_extension_paths
18+
from .mockextensions import _jupyter_server_extension_points
1919

2020
# Testing the first path (which is an extension app).
21-
metadata_list = _jupyter_server_extension_paths()
21+
metadata_list = _jupyter_server_extension_points()
2222
point = metadata_list[0]
2323

2424
module = point["module"]
@@ -47,10 +47,10 @@ def test_extension_point_notfound_error():
4747

4848
def test_extension_package_api():
4949
# Import mock extension metadata
50-
from .mockextensions import _jupyter_server_extension_paths
50+
from .mockextensions import _jupyter_server_extension_points
5151

5252
# Testing the first path (which is an extension app).
53-
metadata_list = _jupyter_server_extension_paths()
53+
metadata_list = _jupyter_server_extension_points()
5454
path1 = metadata_list[0]
5555
app = path1["app"]
5656

0 commit comments

Comments
 (0)