Merge pull request #177 from kevin-bates/remove-py38-ipykernel-patch

Remove win-py38 ipykernel patch

Author: Zsailer

.github/workflows/main.yml

@@ -24,10 +24,6 @@ jobs:
     - name: Install the Python dependencies
       run: |
         pip install -e .[test]
-    - name: ipykernel fix on windows 3.8
-      if: matrix.os == 'windows-latest' && matrix.python-version == '3.8'
-      run: |
-        pip install --upgrade git+https://github.com/ipython/ipykernel.git
     - name: Run the tests
       run: |
         pytest

appveyor.yml

@@ -34,8 +34,6 @@ install:
   - cmd: conda create -y -q -n test-env-%CONDA_PY% python=%CONDA_PY_SPEC% pip pyzmq tornado jupyter_client nbformat nbconvert nose
   - cmd: conda activate test-env-%CONDA_PY%
   - cmd: pip install -e .[test]
-# FIXME: Use patch for python 3.8, windows issues (https://github.com/ipython/ipykernel/pull/456) - remove once released
-  - IF %CONDA_PY% == 38 pip install --upgrade git+https://github.com/ipython/ipykernel.git
 
 test_script:
   - pytest -s -v

setup.py

@@ -92,7 +92,7 @@
     ],
     extras_require = {
         'test': ['nose', 'coverage', 'requests', 'nose_warnings_filters',
-                 'pytest', 'pytest-cov', 'pytest-tornasync', 'pytest-console-scripts'],
+                 'pytest==5.3.2', 'pytest-cov', 'pytest-tornasync', 'pytest-console-scripts'],
         'test:sys_platform == "win32"': ['nose-exclude'],
     },
     python_requires = '>=3.5',