use JinjaMixin

Author: echarles

examples/simple/README.md

@@ -135,7 +135,7 @@ Try with the above links to check that only Extension 2 is responding (Extension
 
 Run `jupyter simple-ext11 --generate-config && vi ~/.jupyter/jupyter_config.py`.
 
-> --generate-config returns an exception `"The ExtensionApp has not ServerApp "`
+> TODO `--generate-config` returns an exception `"The ExtensionApp has not ServerApp "`
 
 The generated configuration should contains the following.
 

examples/simple/simple_ext1/application.py

@@ -1,13 +1,13 @@
 import os, jinja2
 from traitlets import Unicode
-from jupyter_server.extension.application import ExtensionApp
+from jupyter_server.extension.application import ExtensionApp, ExtensionAppJinjaMixin
 from .handlers import (DefaultHandler, RedirectHandler, 
   ParameterHandler, TemplateHandler, TypescriptHandler, ErrorHandler)
 
 DEFAULT_STATIC_FILES_PATH = os.path.join(os.path.dirname(__file__), "static")
 DEFAULT_TEMPLATE_FILES_PATH = os.path.join(os.path.dirname(__file__), "templates")
 
-class SimpleApp1(ExtensionApp):
+class SimpleApp1(ExtensionAppJinjaMixin, ExtensionApp):
 
     # The name of the extension.
     extension_name = "simple_ext1"

examples/simple/simple_ext1/handlers.py

@@ -1,4 +1,4 @@
-from jupyter_server.extension.handler import ExtensionHandler
+from jupyter_server.extension.handler import ExtensionHandler, ExtensionHandlerJinjaMixin
 
 class DefaultHandler(ExtensionHandler):
     def get(self):
@@ -22,10 +22,7 @@ def get(self, matched_part=None, *args, **kwargs):
         self.write('<p>var1: {}</p>'.format(var1))
         self.write('<p>components: {}</p>'.format(components))
 
-class BaseTemplateHandler(ExtensionHandler):
-    def get_template(self, path):
-        """Return the jinja template object for a given name"""
-        return self.settings['{}_jinja2_env'.format(self.extension_name)].get_template(path)
+class BaseTemplateHandler(ExtensionHandlerJinjaMixin, ExtensionHandler): pass
 
 class TypescriptHandler(BaseTemplateHandler):
     def get(self):

examples/simple/simple_ext11/application.py

@@ -47,7 +47,7 @@ class SimpleApp11(SimpleApp1):
 
     @observe('ignore_js')
     def _update_ignore_js(self, change):
-        """TODO The observe does not work"""
+        """TODO Does the observe work?"""
         self.log.info('ignore_js has just changed: {}'.format(change))
 
     @property

examples/simple/simple_ext2/application.py

@@ -1,12 +1,12 @@
 import os, jinja2
 from traitlets import Unicode
-from jupyter_server.extension.application import ExtensionApp
+from jupyter_server.extension.application import ExtensionApp, ExtensionAppJinjaMixin
 from .handlers import ParameterHandler, TemplateHandler, IndexHandler, ErrorHandler
 
 DEFAULT_STATIC_FILES_PATH = os.path.join(os.path.dirname(__file__), "static")
 DEFAULT_TEMPLATE_FILES_PATH = os.path.join(os.path.dirname(__file__), "templates")
 
-class SimpleApp2(ExtensionApp):
+class SimpleApp2(ExtensionAppJinjaMixin, ExtensionApp):
 
     # The name of the extension.
     extension_name = "simple_ext2"

examples/simple/simple_ext2/handlers.py

@@ -1,4 +1,4 @@
-from jupyter_server.extension.handler import ExtensionHandler
+from jupyter_server.extension.handler import ExtensionHandler, ExtensionHandlerJinjaMixin
 
 class ParameterHandler(ExtensionHandler):
     def get(self, matched_part=None, *args, **kwargs):
@@ -9,10 +9,7 @@ def get(self, matched_part=None, *args, **kwargs):
         self.write('<p>var1: {}</p>'.format(var1))
         self.write('<p>components: {}</p>'.format(components))
 
-class BaseTemplateHandler(ExtensionHandler):
-    def get_template(self, name):
-        """Return the jinja template object for a given name"""
-        return self.settings['simple_ext2_jinja2_env'].get_template(name)
+class BaseTemplateHandler(ExtensionHandlerJinjaMixin, ExtensionHandler): pass
 
 class IndexHandler(BaseTemplateHandler):
     def get(self):