Merge pull request #289 from Zsailer/static-url-prefix-fix

make static_url_prefix configurable

Author: blink1073

jupyter_server/extension/application.py

@@ -188,9 +188,13 @@ def _default_log_format(self):
         """override default log format to include date & time"""
         return u"%(color)s[%(levelname)1.1s %(asctime)s.%(msecs).03d %(name)s]%(end_color)s %(message)s"
 
-    @property
-    def static_url_prefix(self):
-        static_url = "static/{name}".format(
+    static_url_prefix = Unicode(
+        help="""Url where the static assets for the extension are served."""
+    ).tag(config=True)
+
+    @default('static_url_prefix')
+    def _default_static_url_prefix(self):
+        static_url = "static/{name}/".format(
             name=self.name
         )
         return urljoin(self.serverapp.base_url, static_url)
@@ -429,7 +433,7 @@ def launch_instance(cls, argv=None, **kwargs):
         if argv is None:
             args = sys.argv[1:]  # slice out extension config.
         else:
-            args = []
+            args = argv
         # Check for subcommands
         subapp = _preparse_for_subcommand(cls, args)
         if subapp:

jupyter_server/extension/handler.py

@@ -56,10 +56,7 @@ def base_url(self):
 
     @property
     def static_url_prefix(self):
-        static_url = "static/{name}".format(
-            name=self.name
-        )
-        return urljoin(self.serverapp.base_url, static_url)
+        return self.extensionapp.static_url_prefix
 
     @property
     def static_path(self):