Skip to content

Commit 627898f

Browse files
authored
Merge pull request #511 from higgsb0/use_kernel_id
Use kernel_id for new kernel if it doesn't exist in MappingKernelManager.start_kernel
2 parents 3927d28 + 20f93cc commit 627898f

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

jupyter_server/services/kernels/kernelmanager.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,9 +179,11 @@ async def start_kernel(self, kernel_id=None, path=None, **kwargs):
179179
The name identifying which kernel spec to launch. This is ignored if
180180
an existing kernel is returned, but it may be checked in the future.
181181
"""
182-
if kernel_id is None:
182+
if kernel_id is None or kernel_id not in self:
183183
if path is not None:
184184
kwargs['cwd'] = self.cwd_for_path(path)
185+
if kernel_id is not None:
186+
kwargs['kernel_id'] = kernel_id
185187
kernel_id = await ensure_async(self.pinned_superclass.start_kernel(self, **kwargs))
186188
self._kernel_connections[kernel_id] = 0
187189
self._kernel_ports[kernel_id] = self._kernels[kernel_id].ports
@@ -201,7 +203,6 @@ async def start_kernel(self, kernel_id=None, path=None, **kwargs):
201203
).inc()
202204

203205
else:
204-
self._check_kernel_id(kernel_id)
205206
self.log.info("Using existing kernel: %s" % kernel_id)
206207

207208
# Initialize culling if not already

0 commit comments

Comments
 (0)