Skip to content

Commit 65617ff

Browse files
Zsailerecharles
authored andcommitted
[MRG] link server extension subcommands to main app (#157)
* link server extension subcommands to main app * Refactor extension subapp interface and add tests * remove f-strings for 3.5 🤦 * change ModuleNotFoundError to ImportError for py3.5
1 parent b8ea3a6 commit 65617ff

14 files changed

+389
-398
lines changed

CONTRIBUTING.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ To run the Python tests, use::
6969

7070
If you want coverage statistics as well, you can run::
7171

72-
py.test --cov notebook -v --pyargs jupyter_server
72+
py.test --cov notebook -v
7373

7474
Building the Documentation
7575
--------------------------
@@ -82,7 +82,7 @@ containing all the necessary packages (except pandoc), use::
8282

8383
conda env create -f docs/environment.yml
8484
source activate server_docs # Linux and OS X
85-
activate notebook_docs # Windows
85+
activate server_docs # Windows
8686

8787
.. _conda environment:
8888
https://conda.io/projects/conda/en/latest/user-guide/tasks/manage-environments.html#creating-an-environment-from-an-environment-yml-file

jupyter_server/extension/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +0,0 @@
1-
from .application import ExtensionApp
2-
from .handler import ExtensionHandler

jupyter_server/extension/application.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,6 @@ def load_jupyter_server_extension(cls, serverapp, argv=[], **kwargs):
418418
extension.initialize(serverapp, argv=argv)
419419
return extension
420420

421-
422421
@classmethod
423422
def launch_instance(cls, argv=None, **kwargs):
424423
"""Launch the extension like an application. Initializes+configs a stock server

0 commit comments

Comments
 (0)