Skip to content

Commit 65e990e

Browse files
Fix to remove potential memory leak on Jupyter Server ZMQChannelHandler code (#682)
Co-authored-by: Steven Silvester <[email protected]>
1 parent 87ab9bb commit 65e990e

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

jupyter_server/services/kernels/handlers.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,10 @@ async def _register_session(self):
387387
if stale_handler:
388388
self.log.warning("Replacing stale connection: %s", self.session_key)
389389
await stale_handler.close()
390-
self._open_sessions[self.session_key] = self
390+
if (
391+
self.kernel_id in self.kernel_manager
392+
): # only update open sessions if kernel is actively managed
393+
self._open_sessions[self.session_key] = self
391394

392395
def open(self, kernel_id):
393396
super(ZMQChannelsHandler, self).open()

0 commit comments

Comments
 (0)