Skip to content

Commit 66ef12d

Browse files
authored
Fix sdist test (#736)
1 parent 2d01be6 commit 66ef12d

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

.github/workflows/python-linux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ jobs:
144144
mkdir test
145145
tar --strip-components=1 -zxvf jupyter_server* -C ./test
146146
cd test
147-
pip install -e .[test]
147+
pip install .[test]
148148
pip install pytest-github-actions-annotate-failures
149149
- name: Run Test
150150
run: |

jupyter_server/log.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def log_request(handler):
5252
if status >= 500 and status != 502:
5353
# Log a subset of the headers if it caused an error.
5454
headers = {}
55-
for header in ['Host', 'Accept', 'Referer', 'User-Agent']:
55+
for header in ["Host", "Accept", "Referer", "User-Agent"]:
5656
if header in request.headers:
5757
headers[header] = request.headers[header]
5858
log_method(json.dumps(headers, indent=2))

tests/extension/test_launch.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,17 +57,19 @@ def _kill_extension_app():
5757
if add_token:
5858
f'--ServerApp.token="{token}"',
5959

60+
root = Path(HERE).parent.parent
61+
6062
process = subprocess.Popen(
6163
[
6264
sys.executable,
6365
"-m",
64-
"mockextensions.app",
66+
"tests.extension.mockextensions.app",
6567
f"--port={port}",
6668
"--ip=127.0.0.1",
6769
"--no-browser",
6870
*argv,
6971
],
70-
cwd=HERE,
72+
cwd=str(root),
7173
)
7274

7375
request.addfinalizer(_kill_extension_app)

0 commit comments

Comments
 (0)