Replace old nose tests with pytest based tests (#152)

* separate eventloop init/start from webapp init/start

* allow_none in ssl options

* add docstrings and protect the http_server property

* replace old nose tests with pytest tests

* remove old tests location

* Reapply test changes from PR 139 to fix gateway test

* decode json models on 3.5

* workaround tornado py38 compatibility issue

* use fixture for asyncio

* try with new_httpserver=True

* reset new httpserver=False

* pin nbconvert

* add fixture for tornado io_loop

* trigger build

* polish the windows 3.8 fix and handle nbconvert encoding properly

* try extending request timeout

* make patch dependent on platform

* increase request timeout in ws

* increase connection time:

* Address deprecation warnings in gateway tests

* add sleep before connecting to running kernel

* missing kernel shutdown in serverapp

* temporarily remove other kernel tests

* check that patch is applied in windoes 3.8

* stop using static method

* increase connection time

* update to versions of python appveyor

* add old tests back in

* add conda line back to appveyor

* add python 38

* Pull ipykernel from GH to fix Windows tests on 3.8

* pull ipykernel master to fix Windows 3.8 issue

Author: Zsailer

.github/workflows/main.yml

@@ -1,4 +1,4 @@
-name: CI
+name: Jupyter Server Tests
 on:
   push:
     branches: 
@@ -24,6 +24,10 @@ jobs:
     - name: Install the Python dependencies
       run: |
         pip install -e .[test]
+    - name: ipykernel fix on windows 3.8
+      if: matrix.os == 'windows-latest' && matrix.python-version == '3.8'
+      run: |
+        pip install --upgrade git+https://github.com/ipython/ipykernel.git
     - name: Run the tests
       run: |
-        nosetests -v jupyter_server
+        pytest

.travis.yml

@@ -37,7 +37,7 @@ script:
       else
           true
       fi
-    - 'if [[ $GROUP == python ]]; then nosetests -v jupyter_server; fi'
+    - 'if [[ $GROUP == python ]]; then pytest; fi'
     - |
       if [[ $GROUP == docs ]]; then
         EXIT_STATUS=0

appveyor.yml

@@ -5,13 +5,18 @@ matrix:
 environment:
   matrix:
     - CONDA_PY: 35
-      CONDA_INSTALL_LOCN: "C:\\Miniconda36-x64"
+      CONDA_PY_SPEC: 3.5
+      CONDA_INSTALL_LOCN: "C:\\Miniconda35-x64"
     - CONDA_PY: 36
+      CONDA_PY_SPEC: 3.6
       CONDA_INSTALL_LOCN: "C:\\Miniconda36-x64"
     - CONDA_PY: 37
-      CONDA_INSTALL_LOCN: "C:\\Miniconda36-x64"
+      CONDA_PY_SPEC: 3.7
+      CONDA_INSTALL_LOCN: "C:\\Miniconda37-x64"
     - CONDA_PY: 38
-      CONDA_INSTALL_LOCN: "C:\\Miniconda36-x64"
+      CONDA_PY_SPEC: 3.8
+      # appveyor doesn't come with this directory, so use 37's since we're creating an env anyway
+      CONDA_INSTALL_LOCN: "C:\\Miniconda37-x64"
 
 platform:
   - x64
@@ -20,11 +25,17 @@ build: off
 
 install:
   - cmd: call %CONDA_INSTALL_LOCN%\Scripts\activate.bat
+  - cmd: set CONDA_PY=%CONDA_PY%
+  - cmd: set CONDA_PY_SPEC=%CONDA_PY_SPEC%
   - cmd: conda config --set show_channel_urls true
   - cmd: conda config --add channels conda-forge
-  #- cmd: conda update --yes --quiet conda
-  - cmd: conda install -y pyzmq tornado jupyter_client nbformat nbconvert ipykernel pip nose
+  - cmd: conda update --yes --quiet conda
+  - cmd: conda info -a
+  - cmd: conda create -y -q -n test-env-%CONDA_PY% python=%CONDA_PY_SPEC% pyzmq tornado jupyter_client nbformat nbconvert ipykernel pip nose
+  - cmd: conda activate test-env-%CONDA_PY%
   - cmd: pip install .[test]
+# FIXME: Use patch for python 3.8, windows issues (https://github.com/ipython/ipykernel/pull/456) - remove once released
+  - IF %CONDA_PY% == 38 pip install --upgrade git+https://github.com/ipython/ipykernel.git
 
 test_script:
-  - nosetests  -v jupyter_server --exclude-dir jupyter_server\tests\selenium
+  - pytest