Skip to content

Commit 6dae409

Browse files
committed
Remove win-py38 ipykernel patch
1 parent 5f99e53 commit 6dae409

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

.github/workflows/main.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@ jobs:
2424
- name: Install the Python dependencies
2525
run: |
2626
pip install -e .[test]
27-
- name: ipykernel fix on windows 3.8
28-
if: matrix.os == 'windows-latest' && matrix.python-version == '3.8'
29-
run: |
30-
pip install --upgrade git+https://github.com/ipython/ipykernel.git
3127
- name: Run the tests
3228
run: |
3329
pytest

appveyor.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ install:
3434
- cmd: conda create -y -q -n test-env-%CONDA_PY% python=%CONDA_PY_SPEC% pip pyzmq tornado jupyter_client nbformat nbconvert nose
3535
- cmd: conda activate test-env-%CONDA_PY%
3636
- cmd: pip install -e .[test]
37-
# FIXME: Use patch for python 3.8, windows issues (https://github.com/ipython/ipykernel/pull/456) - remove once released
38-
- IF %CONDA_PY% == 38 pip install --upgrade git+https://github.com/ipython/ipykernel.git
3937

4038
test_script:
4139
- pytest -s -v

0 commit comments

Comments
 (0)