Merge pull request #3630 from arovit/add_find_replace_test

[WIP: 838] Add find replace test

Author: takluyver

notebook/static/notebook/js/searchandreplace.js

@@ -163,6 +163,7 @@ define([
 
       var allCellsButton = $('<button/>')
       .append($('<i/>').addClass('fa fa-arrows-v'))
+      .attr('id', 'findreplace_allcells_btn')
       .attr('type', 'button')
       .addClass("btn btn-default btn-sm")
       .attr('data-toggle','button')
@@ -179,6 +180,7 @@ define([
 
     var search  = $("<input/>")
       .addClass('form-control input-sm')
+      .attr('id', 'findreplace_find_inp')
       .attr('placeholder',i18n.msg._('Find'));
 
     var findFormGroup = $('<div/>').addClass('form-group');
@@ -194,6 +196,7 @@ define([
     )
 
     var replace = $("<input/>")
+      .attr('id', 'findreplace_replace_inp')
       .addClass('form-control input-sm')
       .attr('placeholder',i18n.msg._('Replace'));
     var replaceFormGroup = $('<div/>').addClass('form-group');
@@ -354,7 +357,8 @@ define([
       keyboard_manager: env.notebook.keyboard_manager,
       buttons:{
         'Replace All':{ class: "btn-primary",
-            click: function(event){onsubmit(event); return true;}
+            click: function(event){onsubmit(event); return true;},
+            id: "findreplace_replaceall_btn",
         }
       },
       open: function(){

notebook/tests/selenium/test_find_and_replace.py

@@ -0,0 +1,24 @@
+import pytest
+
+
+def test_find_and_replace(notebook):
+    """ test find and replace on all the cells """
+    cell_0, cell_1, cell_2, cell_3 = "hello", "hellohello", "abc", "ello"
+
+    find_str = "ello"                            # string to replace
+    replace_str = "foo"                          # string to replace to
+
+    # set the contents of the cells
+    notebook.add_cell(index=0, content=cell_0);
+    notebook.add_cell(index=1, content=cell_1);
+    notebook.add_cell(index=2, content=cell_2);
+    notebook.add_cell(index=3, content=cell_3);
+
+    # replace the strings
+    notebook.find_and_replace(index=0, find_txt=find_str, replace_txt=replace_str)
+
+    # check content of the cells
+    assert notebook.get_cell_contents(0) == cell_0.replace(find_str, replace_str)
+    assert notebook.get_cell_contents(1) == cell_1.replace(find_str, replace_str)
+    assert notebook.get_cell_contents(2) == cell_2.replace(find_str, replace_str)
+    assert notebook.get_cell_contents(3) == cell_3.replace(find_str, replace_str)

notebook/tests/selenium/utils.py

@@ -1,5 +1,5 @@
 import os
-
+import time
 from selenium.webdriver import ActionChains
 from selenium.webdriver.common.by import By
 from selenium.webdriver.common.keys import Keys
@@ -100,6 +100,16 @@ def focus_cell(self, index=0):
         self.to_command_mode()
         self.current_cell = cell
 
+    def find_and_replace(self, index=0, find_txt='', replace_txt=''):
+        self.focus_cell(index)
+        self.to_command_mode()
+        self.body.send_keys('f')
+        wait_for_selector(self.browser, "#find-and-replace", single=True)
+        self.browser.find_element_by_id("findreplace_allcells_btn").click()
+        self.browser.find_element_by_id("findreplace_find_inp").send_keys(find_txt)
+        self.browser.find_element_by_id("findreplace_replace_inp").send_keys(replace_txt)
+        self.browser.find_element_by_id("findreplace_replaceall_btn").click()
+
     def convert_cell_type(self, index=0, cell_type="code"):
         # TODO add check to see if it is already present
         self.focus_cell(index)
@@ -258,3 +268,4 @@ def ctrl(browser, k):
     """Send key combination Ctrl+(k)"""
     ActionChains(browser)\
         .key_down(Keys.CONTROL).send_keys(k).key_up(Keys.CONTROL).perform()
+