Skip to content

Commit 7231909

Browse files
vidartfSteven Silvester
authored andcommitted
Respect reraise setting
We have this nice setting for having extension load failure raise errors instead of silently failing. We should respect it 😄
1 parent e3a146e commit 7231909

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

jupyter_server/extension/manager.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -340,6 +340,8 @@ def link_extension(self, name, serverapp):
340340
self.linked_extensions[name] = True
341341
self.log.info("{name} | extension was successfully linked.".format(name=name))
342342
except Exception as e:
343+
if serverapp.reraise_server_extension_failures:
344+
raise
343345
self.log.warning(e)
344346

345347
def load_extension(self, name, serverapp):
@@ -349,6 +351,8 @@ def load_extension(self, name, serverapp):
349351
try:
350352
points = extension.load_all_points(serverapp)
351353
except Exception as e:
354+
if serverapp.reraise_server_extension_failures:
355+
raise
352356
self.log.debug("".join(traceback.format_exception(*sys.exc_info())))
353357
self.log.warning(
354358
"{name} | extension failed loading with message: {error}".format(

0 commit comments

Comments
 (0)