Skip to content

Commit 898ac31

Browse files
committed
Fix tests on py 2
1 parent d6b8efe commit 898ac31

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

jupyter_server/tests/test_gateway.py

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from datetime import datetime
66
from tornado import gen
77
from tornado.httpclient import HTTPRequest, HTTPResponse, HTTPError
8-
from traitlets.config import Config
8+
from ipython_genutils.py3compat import str_to_unicode
99
from .launchserver import ServerTestBase
1010
from jupyter_server.gateway.managers import GatewayClient
1111

@@ -57,7 +57,7 @@ def mock_gateway_request(url, **kwargs):
5757

5858
# Fetch all kernelspecs
5959
if endpoint.endswith('/api/kernelspecs') and method == 'GET':
60-
response_buf = StringIO(json.dumps(kernelspecs))
60+
response_buf = StringIO(str_to_unicode(json.dumps(kernelspecs)))
6161
response = yield gen.maybe_future(HTTPResponse(request, 200, buffer=response_buf))
6262
raise gen.Return(response)
6363

@@ -66,7 +66,7 @@ def mock_gateway_request(url, **kwargs):
6666
requested_kernelspec = endpoint.rpartition('/')[2]
6767
kspecs = kernelspecs.get('kernelspecs')
6868
if requested_kernelspec in kspecs:
69-
response_buf = StringIO(json.dumps(kspecs.get(requested_kernelspec)))
69+
response_buf = StringIO(str_to_unicode(json.dumps(kspecs.get(requested_kernelspec))))
7070
response = yield gen.maybe_future(HTTPResponse(request, 200, buffer=response_buf))
7171
raise gen.Return(response)
7272
else:
@@ -81,7 +81,7 @@ def mock_gateway_request(url, **kwargs):
8181
nt.assert_equal(name, kspec_name) # Ensure that KERNEL_ env values get propagated
8282
model = generate_model(name)
8383
running_kernels[model.get('id')] = model # Register model as a running kernel
84-
response_buf = StringIO(json.dumps(model))
84+
response_buf = StringIO(str_to_unicode(json.dumps(model)))
8585
response = yield gen.maybe_future(HTTPResponse(request, 201, buffer=response_buf))
8686
raise gen.Return(response)
8787

@@ -91,7 +91,7 @@ def mock_gateway_request(url, **kwargs):
9191
for kernel_id in running_kernels.keys():
9292
model = running_kernels.get(kernel_id)
9393
kernels.append(model)
94-
response_buf = StringIO(json.dumps(kernels))
94+
response_buf = StringIO(str_to_unicode(json.dumps(kernels)))
9595
response = yield gen.maybe_future(HTTPResponse(request, 200, buffer=response_buf))
9696
raise gen.Return(response)
9797

@@ -107,7 +107,7 @@ def mock_gateway_request(url, **kwargs):
107107
raise HTTPError(404, message='Kernel does not exist: %s' % requested_kernel_id)
108108
elif action == 'restart':
109109
if requested_kernel_id in running_kernels:
110-
response_buf = StringIO(json.dumps(running_kernels.get(requested_kernel_id)))
110+
response_buf = StringIO(str_to_unicode(json.dumps(running_kernels.get(requested_kernel_id))))
111111
response = yield gen.maybe_future(HTTPResponse(request, 204, buffer=response_buf))
112112
raise gen.Return(response)
113113
else:
@@ -123,10 +123,10 @@ def mock_gateway_request(url, **kwargs):
123123
raise gen.Return(response)
124124

125125
# Fetch existing kernel
126-
if endpoint.rfind('/api/kernels/') >= 0 and method == 'GET':
127-
requested_kernel_id = endpoint.rpartition('/')[2]
126+
if endpoint.rfind('/api/kernels/') >= 0 and method == 'GET':
127+
requested_kernel_id = endpoint.rpartition('/')[2]
128128
if requested_kernel_id in running_kernels:
129-
response_buf = StringIO(json.dumps(running_kernels.get(requested_kernel_id)))
129+
response_buf = StringIO(str_to_unicode(json.dumps(running_kernels.get(requested_kernel_id))))
130130
response = yield gen.maybe_future(HTTPResponse(request, 200, buffer=response_buf))
131131
raise gen.Return(response)
132132
else:
@@ -351,4 +351,3 @@ def delete_kernel(self, kernel_id):
351351
response = self.request('DELETE', '/api/kernels/' + kernel_id)
352352
self.assertEqual(response.status_code, 204)
353353
self.assertEqual(response.reason, 'No Content')
354-

0 commit comments

Comments
 (0)