2
2
from traitlets .config import Config
3
3
4
4
from jupyter_client .blocking .client import BlockingKernelClient
5
+ from jupyter_client .client import KernelClient
5
6
from jupyter_server .services .kernels .kernelmanager import AsyncMappingKernelManager , ServerKernelManager
6
7
from jupyter_server .utils import import_item
7
8
@@ -33,32 +34,6 @@ def test_not_server_kernel_manager(jp_configurable_serverapp):
33
34
jp_configurable_serverapp (argv = argv )
34
35
35
36
36
- def test_server_kernel_manager_client_class_configurable (jp_configurable_serverapp ):
37
- """Test that ServerKernelManager client_class trait is configurable."""
38
- argv = [
39
- "--AsyncMappingKernelManager.client_class=jupyter_client.asynchronous.AsyncKernelClient"
40
- ]
41
- app = jp_configurable_serverapp (argv = argv )
42
- # Get a kernel manager instance to check the configuration
43
- kernel_manager_class = app .kernel_manager .kernel_manager_class
44
- km_class = import_item (kernel_manager_class )
45
- km_instance = km_class ()
46
- assert km_instance .client_class == "jupyter_client.asynchronous.AsyncKernelClient"
47
-
48
-
49
- def test_server_kernel_manager_client_factory_configurable (jp_configurable_serverapp ):
50
- """Test that ServerKernelManager client_factory trait is configurable."""
51
- argv = [
52
- "--AsyncMappingKernelManager.client_factory=jupyter_client.blocking.client.BlockingKernelClient"
53
- ]
54
- app = jp_configurable_serverapp (argv = argv )
55
- # Get a kernel manager instance to check the configuration
56
- kernel_manager_class = app .kernel_manager .kernel_manager_class
57
- km_class = import_item (kernel_manager_class )
58
- km_instance = km_class ()
59
- assert km_instance .client_factory == BlockingKernelClient
60
-
61
-
62
37
def test_server_kernel_manager_client_traits_via_config ():
63
38
"""Test that ServerKernelManager client traits can be configured via Config object."""
64
39
config = Config ()
@@ -68,3 +43,20 @@ def test_server_kernel_manager_client_traits_via_config():
68
43
km = ServerKernelManager (config = config )
69
44
assert km .client_class == "jupyter_client.blocking.client.BlockingKernelClient"
70
45
assert km .client_factory == BlockingKernelClient
46
+
47
+
48
+ def test_server_kernel_manager_client_traits_default_values ():
49
+ """Test that ServerKernelManager client traits have correct default values."""
50
+ km = ServerKernelManager ()
51
+ assert km .client_class == "jupyter_client.asynchronous.AsyncKernelClient"
52
+ # Default client_factory should be the base KernelClient class
53
+ assert km .client_factory == KernelClient
54
+
55
+
56
+ def test_server_kernel_manager_client_class_string_configuration ():
57
+ """Test that client_class can be configured with different string values."""
58
+ config = Config ()
59
+ config .ServerKernelManager .client_class = "jupyter_client.client.KernelClient"
60
+
61
+ km = ServerKernelManager (config = config )
62
+ assert km .client_class == "jupyter_client.client.KernelClient"
0 commit comments