add missing template for view.html

minrk · minrk · commit 9911fcf53504 · 2021-02-15T13:27:11.000+01:00
and test coverage to exercise it
diff --git a/jupyter_server/templates/view.html b/jupyter_server/templates/view.html
@@ -0,0 +1,30 @@
+<!DOCTYPE HTML>
+<html>
+
+<head>
+  <meta charset="utf-8">
+  <title>{{page_title}}</title>
+  <meta name="viewport" content="width=device-width, initial-scale=1.0">
+</head>
+
+<body>
+  <style type="text/css">
+    html, body, #container {
+      height: 100%;
+    }
+    body, #container {
+      overflow: hidden;
+      margin: 0;
+    }
+    #iframe {
+      width: 100%;
+      height: 100%;
+      border: none;
+    }
+  </style>
+  <div id="container">
+    <iframe id="iframe" sandbox="allow-scripts" src="{{file_url}}"></iframe>
+  </div>
+</body>
+
+</html>
diff --git a/tests/test_view.py b/tests/test_view.py
@@ -0,0 +1,60 @@
+"""test view handler"""
+from html.parser import HTMLParser
+
+import pytest
+import tornado
+
+from jupyter_server.utils import url_path_join
+from .utils import expected_http_error
+
+
+class IFrameSrcFinder(HTMLParser):
+    """Minimal HTML parser to find iframe.src attr"""
+
+    def __init__(self):
+        super().__init__()
+        self.iframe_src = None
+
+    def handle_starttag(self, tag, attrs):
+        if tag.lower() == "iframe":
+            for attr, value in attrs:
+                if attr.lower() == "src":
+                    self.iframe_src = value
+                    return
+
+
+def find_iframe_src(html):
+    """Find the src= attr of an iframe on the page
+
+    Assumes only one iframe
+    """
+    finder = IFrameSrcFinder()
+    finder.feed(html)
+    return finder.iframe_src
+
+
+@pytest.mark.parametrize(
+    "exists, name",
+    [
+        (False, "nosuchfile.html"),
+        (False, "nosuchfile.bin"),
+        (True, "exists.html"),
+        (True, "exists.bin"),
+    ],
+)
+async def test_view(jp_fetch, jp_serverapp, jp_root_dir, exists, name):
+    """Test /view/$path for a few cases"""
+    if exists:
+        jp_root_dir.joinpath(name).write_text(name)
+
+    if not exists:
+        with pytest.raises(tornado.httpclient.HTTPClientError) as e:
+            await jp_fetch("view", name, method="GET")
+        assert expected_http_error(e, 404), [name, e]
+    else:
+        r = await jp_fetch("view", name, method="GET")
+        assert r.code == 200
+        assert r.headers["content-type"] == "text/html; charset=UTF-8"
+        html = r.body.decode()
+        src = find_iframe_src(html)
+        assert src == url_path_join(jp_serverapp.base_url, f"/files/{name}")
