Skip to content

Commit b00f455

Browse files
committed
make config_dir_name in ConfigManager configurable.
1 parent 28d82ab commit b00f455

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

jupyter_server/extension/serverextension.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ def _get_extmanager_for_context(write_dir="jupyter_server_config.d", user=False,
5252
5353
Parameters
5454
----------
55-
55+
write_dir : str [default: 'jupyter_server_config.d']
56+
Name of config directory to write extension config.
5657
user : bool [default: False]
5758
Get the user's .jupyter config directory
5859
sys_prefix : bool [default: False]
@@ -61,7 +62,7 @@ def _get_extmanager_for_context(write_dir="jupyter_server_config.d", user=False,
6162
config_dir = _get_config_dir(user=user, sys_prefix=sys_prefix)
6263
config_manager = ExtensionConfigManager(
6364
read_config_path=[config_dir],
64-
write_config_dir=os.path.join(config_dir, "jupyter_server_config.d"),
65+
write_config_dir=os.path.join(config_dir, write_dir),
6566
)
6667
extension_manager = ExtensionManager(
6768
config_manager=config_manager,

jupyter_server/services/config/manager.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@
1414
class ConfigManager(LoggingConfigurable):
1515
"""Config Manager used for storing frontend config"""
1616

17+
config_dir_name = Unicode(
18+
default="serverconfig",
19+
help="""Name of the config directory."""
20+
).tag(config=True)
21+
1722
# Public API
1823

1924
def get(self, section_name):
@@ -39,13 +44,13 @@ def update(self, section_name, new_data):
3944

4045
@default('read_config_path')
4146
def _default_read_config_path(self):
42-
return [os.path.join(p, 'serverconfig') for p in jupyter_config_path()]
47+
return [os.path.join(p, self.config_dir_name) for p in jupyter_config_path()]
4348

4449
write_config_dir = Unicode()
4550

4651
@default('write_config_dir')
4752
def _default_write_config_dir(self):
48-
return os.path.join(jupyter_config_dir(), 'serverconfig')
53+
return os.path.join(jupyter_config_dir(), self.config_dir_name)
4954

5055
write_config_manager = Instance(BaseJSONConfigManager)
5156

0 commit comments

Comments
 (0)