Skip to content

Commit d273e74

Browse files
authored
Test notebook prerelease (#1064)
* test notebook prerelease * fix test * fix handling of merge config test * more cleanup
1 parent 4b54816 commit d273e74

File tree

2 files changed

+28
-3
lines changed

2 files changed

+28
-3
lines changed

.github/workflows/downstream.yml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,23 @@ jobs:
3535
kill $TASK_PID
3636
wait $TASK_PID
3737
38+
notebook:
39+
runs-on: ubuntu-latest
40+
timeout-minutes: 10
41+
42+
steps:
43+
- name: Checkout
44+
uses: actions/checkout@v3
45+
46+
- name: Base Setup
47+
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
48+
49+
- name: Test notebook
50+
uses: jupyterlab/maintainer-tools/.github/actions/downstream-test@v1
51+
with:
52+
package_name: notebook
53+
package_download_extra_args: "--pre"
54+
3855
jupyterlab_server:
3956
runs-on: ubuntu-latest
4057
timeout-minutes: 10

tests/extension/test_serverextension.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
from collections import OrderedDict
22

33
import pytest
4+
5+
try:
6+
from jupyter_core.paths import prefer_environment_over_user
7+
except ImportError:
8+
prefer_environment_over_user = None
9+
410
from traitlets.tests.utils import check_help_all_output
511

612
from jupyter_server.config_manager import BaseJSONConfigManager
@@ -43,6 +49,7 @@ def test_disable(jp_env_config_path, jp_extension_environ):
4349
assert not config["mock1"]
4450

4551

52+
@pytest.mark.skipif(prefer_environment_over_user is None, reason="Requires jupyter_core 5.0+")
4653
def test_merge_config(jp_env_config_path, jp_configurable_serverapp, jp_extension_environ):
4754
# Toggle each extension module with a JSON config file
4855
# at the sys-prefix config dir.
@@ -62,12 +69,12 @@ def test_merge_config(jp_env_config_path, jp_configurable_serverapp, jp_extensio
6269
# when these two configs merge.
6370
toggle_server_extension_python(
6471
"tests.extension.mockextensions.mockext_both",
65-
enabled=True,
72+
enabled=False,
6673
sys_prefix=True,
6774
)
6875
toggle_server_extension_python(
6976
"tests.extension.mockextensions.mockext_both",
70-
enabled=False,
77+
enabled=True,
7178
user=True,
7279
)
7380

@@ -82,7 +89,8 @@ def test_merge_config(jp_env_config_path, jp_configurable_serverapp, jp_extensio
8289
assert extensions["tests.extension.mockextensions.mockext_sys"]
8390
assert extensions["tests.extension.mockextensions.mockext_py"]
8491
# Merging should causes this extension to be disabled.
85-
assert not extensions["tests.extension.mockextensions.mockext_both"]
92+
if prefer_environment_over_user():
93+
assert not extensions["tests.extension.mockextensions.mockext_both"]
8694

8795

8896
@pytest.mark.parametrize(

0 commit comments

Comments
 (0)