[pre-commit.ci] pre-commit autoupdate (#1266)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Steven Silvester <[email protected]>

Author: pre-commit-ci[bot]

.pre-commit-config.yaml

@@ -35,7 +35,7 @@ repos:
       - id: black
 
   - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: v0.0.260
+    rev: v0.0.263
     hooks:
       - id: ruff
         args: ["--fix"]

jupyter_server/_sysinfo.py

@@ -41,7 +41,7 @@ def pkg_commit_hash(pkg_path):
         if p.exists(p.join(cur_path, ".git")):
             try:
                 proc = subprocess.Popen(
-                    ["git", "rev-parse", "--short", "HEAD"],
+                    ["git", "rev-parse", "--short", "HEAD"],  # noqa
                     stdout=subprocess.PIPE,
                     stderr=subprocess.PIPE,
                     cwd=pkg_path,

jupyter_server/serverapp.py

@@ -2826,10 +2826,9 @@ def start_app(self):
                             "",
                             (
                                 "UNIX sockets are not browser-connectable, but you can tunnel to "
-                                "the instance via e.g.`ssh -L 8888:%s -N user@this_host` and then "
-                                "open e.g. %s in a browser."
-                            )
-                            % (self.sock, self.connection_url),
+                                "the instance via e.g.`ssh -L 8888:{} -N user@this_host` and then "
+                                "open e.g. {} in a browser."
+                            ).format(self.sock, self.connection_url),
                         ]
                     )
                 )

pyproject.toml

@@ -124,7 +124,7 @@ detached = true
 dependencies = [
   "black[jupyter]==23.3.0",
   "mdformat>0.7",
-  "ruff==0.0.260",
+  "ruff==0.0.263",
 ]
 [tool.hatch.envs.lint.scripts]
 style = [
@@ -254,6 +254,10 @@ unfixable = [
 "**/*_config.py" = ["F821"]
 # F401 `jupyter_server_terminals.TerminalAPIHandler` imported but unused
 "jupyter_server/terminal/api_handlers.py" = ["F401"]
+# S607 Starting a process with a partial executable path
+# S603 `subprocess` call: check for execution of untrusted input
+"jupyter_server/services/contents/filemanager.py" = ["S603", "S607"]
+"tests/unix_sockets/test_serverapp_integration.py" = ["S603", "S607"]
 
 [tool.pytest.ini_options]
 addopts = "-raXs --durations 10 --color=yes --doctest-modules"

tests/extension/test_launch.py

@@ -66,7 +66,7 @@ def _kill_extension_app():
         root = Path(HERE).parent.parent
 
         process = subprocess.Popen(
-            [
+            [  # noqa
                 sys.executable,
                 "-m",
                 "tests.extension.mockextensions.app",

tests/services/kernels/test_events.py

@@ -42,7 +42,7 @@ async def mock_method(self, *args, **kwargs):
 
     monkeypatch.setattr(AsyncKernelManager, f"{action}_kernel", mock_method)
 
-    with pytest.raises(Exception):
+    with pytest.raises(Exception):  # noqa
         await getattr(manager, f"{action}_kernel")()
 
     output = jp_read_emitted_events()[0]

tests/test_utils.py

@@ -99,7 +99,7 @@ def test_check_version():
 
 
 def test_check_pid():
-    proc = subprocess.Popen([sys.executable])
+    proc = subprocess.Popen([sys.executable])  # noqa
     proc.kill()
     proc.wait()
     check_pid(proc.pid)