attempt to address naming issues in extension loader

Author: Zsailer

examples/simple/simple_ext1/application.py

@@ -10,10 +10,10 @@
 class SimpleApp1(ExtensionAppJinjaMixin, ExtensionApp):
 
     # The name of the extension.
-    name = "simple_ext1"
+    name = "foo"
 
     # The url that your extension will serve its homepage.
-    extension_url = '/simple_ext1/default'
+    extension_url = '/foo/default'
 
     # Should your extension expose other server extensions when launched directly?
     load_other_extensions = True

jupyter_server/extension/application.py

@@ -153,6 +153,14 @@ class method. This method can be set as a entry_point in
     # this extension from the CLI, e.g. `jupyter {name}`.
     name = None
 
+    @classmethod
+    def get_extension_package(cls):
+        return cls.__module__.split('.')[0]
+
+    @classmethod
+    def get_extension_point(cls):
+        return cls.__module__
+
     # Extension URL sets the default landing page for this extension.
     extension_url = "/"
 
@@ -370,7 +378,7 @@ def stop(self):
     def _jupyter_server_config(cls):
         base_config = {
             "ServerApp": {
-                "jpserver_extensions": {cls.name: True},
+                "jpserver_extensions": {cls.get_extension_package(): True},
                 "open_browser": True,
                 "default_url": cls.extension_url
             }
@@ -389,7 +397,7 @@ def _load_jupyter_server_extension(cls, serverapp):
             extension = extension_manager.extension_points[cls.name].app
         except KeyError:
             extension = cls()
-            extension.link_to_serverapp(serverapp)
+            extension._link_jupyter_server_extension(serverapp)
         extension.initialize()
         return extension
 

jupyter_server/extension/manager.py

@@ -49,7 +49,7 @@ def _valid_metadata(self, proposed):
             self._module = importlib.import_module(self._module_name)
         except ImportError:
             raise ExtensionModuleNotFound(
-                "The module '{}' could not be found. Are you "
+                "The submodule '{}' could not be found. Are you "
                 "sure the extension is installed?".format(self._module_name)
             )
         # Initialize the app object if it exists.

jupyter_server/extension/utils.py

@@ -137,6 +137,17 @@ class ExtensionModuleNotFound(Exception):
     pass
 
 
+class NotAnExtensionApp(Exception):
+    pass
+
+
+def get_extension_app_pkg(app_cls):
+    """Get the Python package name
+    """
+    if not isinstance(app_cls, "ExtensionApp"):
+        raise NotAnExtensionApp("The ")
+
+
 def get_loader(obj):
     """Looks for _load_jupyter_server_extension as an attribute
     of the object or module.

jupyter_server/serverapp.py

@@ -1511,7 +1511,7 @@ def init_server_extensions(self):
 
         # Initialize each extension
         self.extension_manager = ExtensionManager(
-            parent=self,
+            logger=self.log,
             jpserver_extensions=self.jpserver_extensions
         )
         self.extension_manager.link_extensions()