Skip to content

Commit f55c277

Browse files
committed
ensure extension app read config from file and cli
1 parent a4e1d53 commit f55c277

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

jupyter_server/extension/application.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,10 @@ def _default_extension_name(self):
108108

109109
INVALID_EXTENSION_NAME_CHARS = [' ', '.', '+', '/']
110110

111+
def _config_file_name_default(self):
112+
"""The default config file name."""
113+
return 'jupyter_{}_config'.format(self.extension_name)
114+
111115
def _validate_extension_name(self):
112116
value = self.extension_name
113117
if isinstance(value, str):
@@ -211,6 +215,7 @@ def _prepare_config(self):
211215
"""
212216
traits = self.class_own_traits().keys()
213217
self.extension_config = Config({t: getattr(self, t) for t in traits})
218+
self.serverapp.web_app.settings['{}_config'.format(self.extension_name)] = self.extension_config
214219
self.settings['{}_config'.format(self.extension_name)] = self.extension_config
215220

216221
def _prepare_settings(self):

jupyter_server/serverapp.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1207,6 +1207,7 @@ def _update_server_extensions(self, change):
12071207
"""))
12081208

12091209
def parse_command_line(self, argv=None):
1210+
12101211
super(ServerApp, self).parse_command_line(argv)
12111212

12121213
if self.extra_args:

jupyter_server/services/contents/tests/test_contents_api.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,6 @@ def test_delete(self):
507507

508508
for d in self.dirs + ['/']:
509509
nbs = notebooks_only(self.api.list(d).json())
510-
print('------')
511510
print(d)
512511
print(nbs)
513512
self.assertEqual(nbs, [])

0 commit comments

Comments
 (0)