added some comments about uncertainties in the logic / layout

Author: abmercer

jupyter_server/extension/manager.py

@@ -16,6 +16,7 @@
 from .utils import ExtensionMetadataError, ExtensionModuleNotFound, get_loader, get_metadata
 
 
+# probably this should go in it's own file? Not sure where though
 MCP_TOOL_SCHEMA = {
     "type": "object",
     "properties": {
@@ -144,10 +145,11 @@ def tools(self):
         try:
             definitions = tools_func()
             for name, tool in definitions.items():
+                # not sure if we should just pick MCP schema or make the schema something the user can pass
                 jsonschema.validate(instance=tool["metadata"], schema=MCP_TOOL_SCHEMA)
                 tools[name] = tool
         except Exception as e:
-            # You could also `self.log.warning(...)` if you pass the log around
+            # not sure if this should fail quietly, raise an error, or log it? 
             print(f"[tool-discovery] Failed to load tools from {self.module_name}: {e}")
         return tools
 
@@ -508,7 +510,7 @@ def get_tools(self) -> Dict[str, Any]:
                 continue
 
             for point in ext_pkg.extension_points.values():
-                for name, tool in point.tools.items():  # 🔥 <— new property!
+                for name, tool in point.tools.items():  # <— new property!
                     if name in all_tools:
                         raise ValueError(f"Duplicate tool name detected: '{name}'")
                     all_tools[name] = tool

jupyter_server/serverapp.py

@@ -2540,6 +2540,7 @@ def load_server_extensions(self) -> None:
         """
         self.extension_manager.load_all_extensions()
 
+    # is this how I would expose it? and Is this a good name? 
     def get_tools(self): 
         return self.extension_manager.get_tools()
 

jupyter_server/services/contents/handlers.py

@@ -423,11 +423,12 @@ async def post(self, path=""):
         self.set_status(201)
         self.finish()
 
+# Somehow this doesn't feel like the right service for this to go in? 
 class ListToolInfoHandler(APIHandler):
     @web.authenticated
     async def get(self):
         tools = self.serverapp.extension_manager.discover_tools()
-        self.finish({"discovered_tools": tools})
+        self.finish({"discovered_tools": tools}) 
 
 
 # -----------------------------------------------------------------------------