Skip to content

Commit f6c3cad

Browse files
committed
handle sorting of dictionary keys properly
1 parent dadc124 commit f6c3cad

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

jupyter_server/extension/manager.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -209,9 +209,8 @@ def enabled_extensions(self):
209209
"""Dictionary with extension package names as keys
210210
and an ExtensionPackage objects as values.
211211
"""
212-
# Sort enabled extensions before returning
213-
out = sorted(self._enabled_extensions.items())
214-
return dict(out)
212+
# Sort enabled extensions before
213+
return self._enabled_extensions
215214

216215
@property
217216
def extension_points(self):
@@ -260,7 +259,7 @@ def link_all_extensions(self, serverapp):
260259
"""
261260
# Sort the extension names to enforce deterministic linking
262261
# order.
263-
for name in self.enabled_extensions:
262+
for name in sorted(self.enabled_extensions.keys()):
264263
self.link_extension(name, serverapp)
265264

266265
def load_all_extensions(self, serverapp):
@@ -269,6 +268,6 @@ def load_all_extensions(self, serverapp):
269268
"""
270269
# Sort the extension names to enforce deterministic loading
271270
# order.
272-
for name in self.enabled_extensions:
271+
for name in sorted(self.enabled_extensions.keys()):
273272
self.load_extension(name, serverapp)
274273

0 commit comments

Comments
 (0)