Skip to content

Commit fe87f69

Browse files
authored
More cleanup (#1077)
* more test cleanup * add codecov badge * remove unused env var
1 parent 1e18aae commit fe87f69

File tree

5 files changed

+36
-29
lines changed

5 files changed

+36
-29
lines changed

.github/workflows/check-release.yml

Lines changed: 0 additions & 22 deletions
This file was deleted.

.github/workflows/downstream.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,3 +100,18 @@ jobs:
100100
uses: jupyterlab/maintainer-tools/.github/actions/downstream-test@v1
101101
with:
102102
package_name: jupyter_server_terminals
103+
104+
downstream_check: # This job does nothing and is only used for the branch protection
105+
if: always()
106+
needs:
107+
- jupyterlab
108+
- jupyter_server_terminals
109+
- jupyterlab_server
110+
- notebook
111+
- nbclassic
112+
runs-on: ubuntu-latest
113+
steps:
114+
- name: Decide whether the needed jobs succeeded or failed
115+
uses: re-actors/alls-green@release/v1
116+
with:
117+
jobs: ${{ toJSON(needs) }}

.github/workflows/integration-tests.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ jobs:
2929
run: |
3030
hatch run cov:integration
3131
32-
3332
integration_check: # This job does nothing and is only used for the branch protection
3433
if: always()
3534
needs:

.github/workflows/python-tests.yml

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ jobs:
5151
pip install codecov
5252
codecov
5353
54-
pre-commit:
54+
pre_commit:
5555
name: pre-commit
5656
runs-on: ubuntu-latest
5757
steps:
@@ -96,7 +96,6 @@ jobs:
9696
only_create_file: 1
9797
- name: Run the unit tests
9898
run: |
99-
export PIP_CONSTRAINT="./contraints_file.txt"
10099
hatch run test:nowarn || hatch run test:nowarn --lf
101100
102101
test_prereleases:
@@ -110,8 +109,7 @@ jobs:
110109
python_version: "3.11"
111110
- name: Run the tests
112111
run: |
113-
export PIP_PRE=1
114-
hatch run test:nowarn || hatch run test:nowarn --lf
112+
PIP_PRE=1 hatch run test:nowarn || hatch run test:nowarn --lf
115113
116114
make_sdist:
117115
name: Make SDist
@@ -134,6 +132,21 @@ jobs:
134132
package_spec: .
135133
test_command: hatch run test:test || hatch run test:test --lf
136134

135+
check_release:
136+
runs-on: ubuntu-latest
137+
steps:
138+
- name: Checkout
139+
uses: actions/checkout@v3
140+
- name: Base Setup
141+
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
142+
- name: Install Dependencies
143+
run: |
144+
pip install -e .
145+
- name: Check Release
146+
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2
147+
with:
148+
token: ${{ secrets.GITHUB_TOKEN }}
149+
137150
check_links:
138151
name: Check Links
139152
runs-on: ubuntu-latest
@@ -143,15 +156,16 @@ jobs:
143156
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
144157
- uses: jupyterlab/maintainer-tools/.github/actions/check-links@v1
145158

146-
python_tests_check: # This job does nothing and is only used for the branch protection
159+
tests_check: # This job does nothing and is only used for the branch protection
147160
if: always()
148161
needs:
149162
- build
150-
- pre-commit
163+
- pre_commit
151164
- test_docs
152165
- test_minimum_versions
153166
- test_prereleases
154167
- check_links
168+
- check_release
155169
- test_sdist
156170
runs-on: ubuntu-latest
157171
steps:

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# Jupyter Server
22

33
[![Build Status](https://github.com/jupyter-server/jupyter_server/actions/workflows/python-tests.yml/badge.svg?query=branch%3Amain++)](https://github.com/jupyter-server/jupyter_server/actions/workflows/python-tests.yml/badge.svg?query=branch%3Amain++)
4+
[![codecov](https://codecov.io/gh/jupyter-server/jupyter_server/branch/main/graph/badge.svg?token=S9WiBg2iL0)](https://codecov.io/gh/jupyter-server/jupyter_server)
45
[![Documentation Status](https://readthedocs.org/projects/jupyter-server/badge/?version=latest)](http://jupyter-server.readthedocs.io/en/latest/?badge=latest)
56

67
The Jupyter Server provides the backend (i.e. the core services, APIs, and REST endpoints) for Jupyter web applications like Jupyter notebook, JupyterLab, and Voila.

0 commit comments

Comments
 (0)