Question re requests-unixsocket dependency

[lazka]

setup.cfg lists a requests-unixsocket dependency which doesn't work on Windows but is still installed there.

jupyter_server/setup.cfg

Line 45 in 29be9c6

requests-unixsocket

We are trying to package this on Windows and were wondering why this dependency is needed: msys2/MINGW-packages#9922

Looking at the the PR that added it: #525 it seems like it was added by accident and isn't actually used, unless I'm missing something.

[welcome]

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.

You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[Zsailer]

Thank you for reporting, @lazka.

You're right. As @kevin-bates mentions in #599, we removed the need for this dependency by refactoring the tests a bit.

I'll merge #599 and cut a patch release today.

[lazka]

Thanks!

[Zsailer]

v1.11.2 is released with requests-unixsocket removed.